Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: [workstations] Adjust wording around service accounts and control planes #9321

Merged
merged 3 commits into from
Apr 13, 2023
Merged

docs: [workstations] Adjust wording around service accounts and control planes #9321

merged 3 commits into from
Apr 13, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Apr 6, 2023 •
edited
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 522482855

Source-Link: googleapis/googleapis@f0cec0b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/480b18a2766a287abb5d003bc79daa4d6bff5727
Copy-Tag: eyJwIjoiamF2YS13b3Jrc3RhdGlvbnMvLk93bEJvdC55YW1sIiwiaCI6IjQ4MGIxOGEyNzY2YTI4N2FiYjVkMDAzYmM3OWRhYTRkNmJmZjU3MjcifQ==

feat: add client libraries for Workstations v1

PiperOrigin-RevId: 522193471

Source-Link: googleapis/googleapis@5cb1253

Source-Link: https://github.com/googleapis/googleapis-gen/commit/c806967c017f4f02811abaacb9c91bc2861572b1
Copy-Tag: eyJwIjoiamF2YS13b3Jrc3RhdGlvbnMvLk93bEJvdC55YW1sIiwiaCI6ImM4MDY5NjdjMDE3ZjRmMDI4MTFhYmFhY2I5YzkxYmMyODYxNTcyYjEifQ==

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2023
@snippet-bot
Copy link

snippet-bot bot commented Apr 6, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 104 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2023
@gcf-owl-bot gcf-owl-bot bot changed the title feat: [workstations] add client libraries for Workstations v1 docs: [workstations] Adjust wording around service accounts and control planes Apr 7, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 7, 2023
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Apr 12, 2023

Owl bot is regenerating pull request 9321...
Build name: NjQzNGM1MzEtNTQxZC00ZGE1LTg3NDctMDg1OTYwMzc1NzEx

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-workstations branch from 3eaaa0a to 616d679 Compare April 12, 2023 18:29
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Apr 13, 2023

Owl bot is regenerating pull request 9321...
Build name: NjdlYzI5YTQtMDFmZi00OTJkLWJhMTYtMjdkMzMwMDIxMDY4

@gcf-owl-bot
docs: Adjust wording around service accounts and control planes
590e3d0 
PiperOrigin-RevId: 522482855

Source-Link: googleapis/googleapis@f0cec0b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/480b18a2766a287abb5d003bc79daa4d6bff5727
Copy-Tag: eyJwIjoiamF2YS13b3Jrc3RhdGlvbnMvLk93bEJvdC55YW1sIiwiaCI6IjQ4MGIxOGEyNzY2YTI4N2FiYjVkMDAzYmM3OWRhYTRkNmJmZjU3MjcifQ==

feat: add client libraries for Workstations v1

PiperOrigin-RevId: 522193471

Source-Link: googleapis/googleapis@5cb1253

Source-Link: https://github.com/googleapis/googleapis-gen/commit/c806967c017f4f02811abaacb9c91bc2861572b1
Copy-Tag: eyJwIjoiamF2YS13b3Jrc3RhdGlvbnMvLk93bEJvdC55YW1sIiwiaCI6ImM4MDY5NjdjMDE3ZjRmMDI4MTFhYmFhY2I5YzkxYmMyODYxNTcyYjEifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-workstations branch from 1ad57a2 to 590e3d0 Compare April 13, 2023 13:03
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@JoeWang1127
Copy link
Contributor

consolidate-config failed with error:

diff --git a/java-workstations/grpc-google-cloud-workstations-v1/pom.xml b/java-workstations/grpc-google-cloud-workstations-v1/pom.xml
index bd1892a33..64a9f89c3 100644
--- a/java-workstations/grpc-google-cloud-workstations-v1/pom.xml
+++ b/java-workstations/grpc-google-cloud-workstations-v1/pom.xml
@@ -42,28 +42,4 @@
       <artifactId>guava</artifactId>
     </dependency>
   </dependencies>
-
-  <profiles>
-    <profile>
-      <id>java9</id>
-      <activation>
-        <jdk>[9,)</jdk>
-      </activation>
-      <dependencies>
-        <dependency>
-          <groupId>javax.annotation</groupId>
-          <artifactId>javax.annotation-api</artifactId>
-        </dependency>
-      </dependencies>
-    </profile>
-  </profiles>
-
-  <build>
-    <plugins>
-      <plugin>
-          <groupId>org.codehaus.mojo</groupId>
-          <artifactId>flatten-maven-plugin</artifactId>
-        </plugin>
-    </plugins>
-  </build>
 </project>
\ No newline at end of file
diff --git a/java-workstations/proto-google-cloud-workstations-v1/pom.xml b/java-workstations/proto-google-cloud-workstations-v1/pom.xml
index 2b[5](https://github.com/googleapis/google-cloud-java/actions/runs/4689609672/jobs/8311576062?pr=9321#step:4:6)7741da..2a8952b5e 100[6](https://github.com/googleapis/google-cloud-java/actions/runs/4689609672/jobs/8311576062?pr=9321#step:4:7)44
--- a/java-workstations/proto-google-cloud-workstations-v1/pom.xml
+++ b/java-workstations/proto-google-cloud-workstations-v1/pom.xml
@@ -34,13 +34,4 @@
       <artifactId>guava</artifactId>
     </dependency>
   </dependencies>
-
-  <build>
-    <plugins>
-      <plugin>
-          <groupId>org.codehaus.mojo</groupId>
-          <artifactId>flatten-maven-plugin</artifactId>
-        </plugin>
-    </plugins>
-  </build>
 </project>
Error: Process completed with exit code 1.

@suztomo
Copy link
Member

suztomo commented Apr 13, 2023

@JoeWang1127 Can you remove the unnecessary lines to pass the check? (consilidate_config shell script helps. You can do the same manually)

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2023
@JoeWang1127
Copy link
Contributor

@JoeWang1127 Can you remove the unnecessary lines to pass the check? (consilidate_config shell script helps. You can do the same manually)

Will do, thanks.

Is there any reason for the difference?

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@JoeWang1127 JoeWang1127 requested a review from suztomo April 13, 2023 14:28
@suztomo
Copy link
Member

suztomo commented Apr 13, 2023

The template in the synthtool is not correct for this repository.

@JoeWang1127 JoeWang1127 merged commit cb475f3 into main Apr 13, 2023
@JoeWang1127 JoeWang1127 deleted the owl-bot-copy-java-workstations branch April 13, 2023 15:48
@release-please release-please bot mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @suztomo @yoshi-kokoro