fix(ci): CHANGELOG.md generation fix for 'no change' and yoshi-code-bot email #9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
changed the title
suztomo
changed the title
suztomo
commented
Jun 21, 2023
| ) | ||
| self.assertEqual(entry, f'''## 1.2.3 (2023-06-10) | ||
|
|
||
| * No change |
There was a problem hiding this comment.
This is the effect of this pull request.
| @@ -22,7 +22,6 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| with: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
The fetch-depth default 1 seems enough. No need to fetch all branches.
https://github.com/actions/checkout#checkout-a-different-branch
| @@ -40,7 +39,7 @@ jobs: | |||
| python3 .github/release-note-generation/split_release_note.py pr_body.txt . | |||
| - name: Commit the change and push to the pull request branch | |||
| run: | | |||
| git config user.email "yoshi-code-bot[bot]@users.noreply.github.com" | |||
| git config user.email "[email protected]" | |||
suztomo
added
the
automerge
burkedavison
approved these changes
Jun 21, 2023
suztomo
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To show 'No change' if there's no change for a library. Before this change, it's blank:
Use proper name in yoshi-code-bot so that it passes CLA.