refactor: drop dependency on createErrorClass (#325)

googleapis · Jun 7, 2019 · aedebee · aedebee
1 parent 9f13086
commit aedebee
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/packages/google-cloud-compute/package.json b/packages/google-cloud-compute/package.json
@@ -41,7 +41,6 @@
     "@google-cloud/promisify": "^1.0.0",
     "arrify": "^2.0.0",
     "async": "^3.0.0",
-    "create-error-class": "^3.0.2",
     "extend": "^3.0.1",
     "gce-images": "^2.0.0",
     "is": "^3.2.1",

diff --git a/packages/google-cloud-compute/src/snapshot.js b/packages/google-cloud-compute/src/snapshot.js
@@ -127,9 +127,7 @@ class Snapshot extends common.ServiceObject {
     const compute = isDisk ? scope.zone.compute : scope;
     const config = {
       parent: scope,
-      baseUrl: `https://${
-        compute.apiEndpoint
-      }/compute/v1/projects/{{projectId}}/global/snapshots`,
+      baseUrl: `https://${compute.apiEndpoint}/compute/v1/projects/{{projectId}}/global/snapshots`,
       /**
        * @name Snapshot#id
        * @type {string}

diff --git a/packages/google-cloud-compute/src/vm.js b/packages/google-cloud-compute/src/vm.js
@@ -17,7 +17,6 @@
 'use strict';
 
 const common = require('@google-cloud/common');
-const createErrorClass = require('create-error-class');
 const format = require('string-format-obj');
 const is = require('is');
 const {promisifyAll} = require('@google-cloud/promisify');
@@ -33,7 +32,12 @@ const Disk = require('./disk.js');
  * @param {string} message - Custom error message.
  * @returns {Error}
  */
-const DetachDiskError = createErrorClass('DetachDiskError');
+class DetachDiskError extends Error {
+  constructor(message) {
+    super(message);
+    this.name = 'DetachDiskError';
+  }
+}
 
 /**
  * Custom error type for when `waitFor()` does not return a status in a timely
@@ -44,7 +48,12 @@ const DetachDiskError = createErrorClass('DetachDiskError');
  * @param {string} message - Custom error message.
  * @returns {Error}
  */
-const WaitForTimeoutError = createErrorClass('WaitForTimeoutError');
+class WaitForTimeoutError extends Error {
+  constructor(message) {
+    super(message);
+    this.name = 'WaitForTimeoutError';
+  }
+}
 
 /**
  * The statuses that a VM can be in.