Skip to content

Commit

Permalink
chore: apply new linting rules. (#523)
Browse files Browse the repository at this point in the history
  • Loading branch information
SurferJeffAtGoogle authored Apr 17, 2020
1 parent 2479ead commit eb3f3c3
Show file tree
Hide file tree
Showing 8 changed files with 3,547 additions and 4,982 deletions.
1,651 changes: 703 additions & 948 deletions packages/google-cloud-translate/src/v3/translation_service_client.ts

Large diffs are not rendered by default.

1,666 changes: 704 additions & 962 deletions packages/google-cloud-translate/src/v3beta1/translation_service_client.ts

Large diffs are not rendered by default.

19 changes: 16 additions & 3 deletions packages/google-cloud-translate/synth.metadata
Original file line number Diff line number Diff line change
@@ -1,12 +1,25 @@
{
"updateTime": "2020-04-11T01:04:33.653333Z",
"sources": [
{
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-translate.git",
"sha": "23f6b4bdf50ce033d268f7ac96633875540ab6b1"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "101d31acd73076c52d78e18322be01f3debe8cb5",
"internalRef": "306855444"
}
},
{
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "6f32150677c9784f3c3a7e1949472bd29c9d72c5",
"log": "6f32150677c9784f3c3a7e1949472bd29c9d72c5\nfix: installs test_utils from its common repo (#480)\n\n\n74ce986d3b5431eb66985e9a00c4eb45295a4020\nfix: stop recording update_time in synth.metadata (#478)\n\n\n7f8e62aa3edd225f76347a16f92e400661fdfb52\nchore(java): release-please only updates non maven versions in README (#476)\n\nPrevent release-please and synthtool from fighting over the released library version. Synthtool updates the install snippets from the samples pom.xml files so the bots fight if they are temporarily out of sync after a release.\nc7e0e517d7f46f77bebd27da2e5afcaa6eee7e25\nbuild(java): fix nightly integration test config to run integrations (#465)\n\nThis was only running the units.\nbd69a2aa7b70875f3c988e269706b22fefbef40e\nbuild(java): fix retry_with_backoff when -e option set (#475)\n\n\nd9b173c427bfa0c6cca818233562e7e8841a357c\nfix: record version of working repo in synth.metadata (#473)\n\nPartial revert of b37cf74d12e9a42b9de9e61a4f26133d7cd9c168.\nf73a541770d95a609e5be6bf6b3b220d17cefcbe\nfeat(discogapic): allow local discovery-artifact-manager (#474)\n\n\n8cf0f5d93a70c3dcb0b4999d3152c46d4d9264bf\ndoc: describe the Autosynth & Synthtool protocol (#472)\n\n* doc: describe the Autosynth & Synthtool protocol\n\n* Accommodate review comments.\n980baaa738a1ad8fa02b4fdbd56be075ee77ece5\nfix: pin sphinx to <3.0.0 as new version causes new error (#471)\n\nThe error `toctree contains reference to document changlelog that doesn't have a title: no link will be generated` occurs as of 3.0.0. Pinning to 2.x until we address the docs build issue.\n\nTowards #470\n\nI did this manually for python-datastore https://github.com/googleapis/python-datastore/pull/22\n928b2998ac5023e7c7e254ab935f9ef022455aad\nchore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#466)\n\nCo-authored-by: Jeffrey Rennie <[email protected]>\n188f1b1d53181f739b98f8aa5d40cfe99eb90c47\nfix: allow local and external deps to be specified (#469)\n\nModify noxfile.py to allow local and external dependencies for\nsystem tests to be specified.\n1df68ed6735ddce6797d0f83641a731c3c3f75b4\nfix: apache license URL (#468)\n\n\nf4a59efa54808c4b958263de87bc666ce41e415f\nfeat: Add discogapic support for GAPICBazel generation (#459)\n\n* feat: Add discogapic support for GAPICBazel generation\n\n* reformat with black\n\n* Rename source repository variable\n\nCo-authored-by: Jeffrey Rennie <[email protected]>\n"
"sha": "682c0c37d1054966ca662a44259e96cc7aea4413"
}
}
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **


/* eslint-disable node/no-missing-require, no-unused-vars */
const translation = require('@google-cloud/translate');

Expand Down
28 changes: 13 additions & 15 deletions packages/google-cloud-translate/system-test/install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,34 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import {packNTest} from 'pack-n-play';
import {readFileSync} from 'fs';
import {describe, it} from 'mocha';
import { packNTest } from 'pack-n-play';
import { readFileSync } from 'fs';
import { describe, it } from 'mocha';

describe('typescript consumer tests', () => {

it('should have correct type signature for typescript users', async function() {
this.timeout(300000);
const options = {
packageDir: process.cwd(), // path to your module.
packageDir: process.cwd(), // path to your module.
sample: {
description: 'typescript based user can use the type definitions',
ts: readFileSync(
'./system-test/fixtures/sample/src/index.ts'
).toString(),
},
ts: readFileSync('./system-test/fixtures/sample/src/index.ts').toString()
}
};
await packNTest(options); // will throw upon error.
await packNTest(options); // will throw upon error.
});

it('should have correct type signature for javascript users', async function() {
this.timeout(300000);
const options = {
packageDir: process.cwd(), // path to your module.
packageDir: process.cwd(), // path to your module.
sample: {
description: 'typescript based user can use the type definitions',
ts: readFileSync(
'./system-test/fixtures/sample/src/index.js'
).toString(),
},
ts: readFileSync('./system-test/fixtures/sample/src/index.js').toString()
}
};
await packNTest(options); // will throw upon error.
await packNTest(options); // will throw upon error.
});

});
Loading

0 comments on commit eb3f3c3

Please sign in to comment.