-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failing in Node 7.x #1753
Comments
This issue was moved to grpc/grpc#8512 |
Sounds like a fix has been made and will be released upstream soon. After that, we'll update accordingly here. Thanks for reporting! |
Build also fails on linux. Perhaps the title should be updated. |
|
This fails for us as well, and our dep is https://travis-ci.org/finn-no/cdn-uploader/builds/173181378 Any timeline for a release? |
@SimenB that seems to be a different issue, see this line:
|
Also unable to run If the upstream grpc depdency has been updated, suggest making a release for that vs waiting for the next feature release of google-cloud. See log output below.
|
I think that could be a matter of needing to rebuild the naive dependency. Can you try 'rm -rf node_modules && npm install'? |
Trying with a blank env without cache was the first thing I tried. I also manually installed grpc 1.0.1 but this didn't actually help, so perhaps their fix hasn't resolved the issue as planned. If I just downgrade to Node 6.9 everything works again with no other changes. Will sit it out for a while. 👍🏻 |
Same here On Wed, Nov 9, 2016 at 6:42 PM Sam Kelleher [email protected]
|
Still failing against Node 7.1.0. Will remove google-cloud dependency until fixed, as we need to run on Node 7 to leverage some ES2017 features. |
@adambuczynski @julien-c @samkelleher @SimenB @randunel We are preparing a release to fix this issue today. Thank you for your patience. @stephenplusplus will provide more details. |
We've released 0.44.0 which hardcodes (via shrinkwrap) [email protected]. Thanks for your patience, everyone! |
@stephenplusplus Will there be precompiled versions of grpc made available for node@7? Also, Yarn ignores shrinkwraps, so you might want to find another solution |
We shrinkwrap to keep the size of the module down for npm < 3 users, by forcing a flatter dependency tree. For any gRPC questions / issues, please direct them to their repo https://github.com/grpc/grpc |
Similar issue in here and we are considering dropping google-cloud. |
@murgatroid99 is in charge. Especially for the usage of Node7, grpc/grpc#9311 (comment) said that:
(I believe that this is not only for Windows but also for any platforms) This would resolve the reported problems mostly. I am, however, wondering if we should wait for the actual 1.1.0 release for google-cloud packages, or we should quickly switch to this "pre1" version now. Any ideas? |
Yes, that is for all platforms. We expect to have the actual 1.1.0 release published this week, so I would recommend changing your dependency to that version at that time. |
any news? |
We have published [email protected], which includes Node 7 support |
I installed [email protected], installation of google-cloud still fails |
Should we consider there is not support for windows? Good job google-cloud! |
@stephenplusplus Do we need to update @bmustata We do support Windows. Please consider that these client libraries are mostly Alpha, except for the four that are Beta level (Datastore, Logging, Storage, and BigQuery). We are working the issue. |
There comes [email protected] which should solve serious known issues and be distributed with pre-built binaries on platforms including Windows. We should upgrade the current dependency to this -- otherwise the installation process will keep failing when a package dependency needs to install [email protected]. |
|
Thanks @stephenplusplus! |
I can confirm it now works! |
For anyone that runs into this issue like I did, make sure to update your node if possible. I was running v0.12.0 of Node and after updating to v7.9.0 I was able to install the grpc package properly, which was stumping the google-cloud package. |
And then when trying to compile:
The text was updated successfully, but these errors were encountered: