pubsub: convert to grpc #1070

stephenplusplus · 2016-01-19T13:55:30Z

This adds support for gRPC APIs where necessary (Service & ServiceObject). This PR also converts Pub/Sub to use gRPC.

To Dos

`mockery` -> `mockery-next`

Mockery wasn't holding up for our use of gRPC in this module. When trying to mock it in two different test suites, mockery couldn't handle it. I found mockery-next handles it quite well: cspotcode/mockery-next#6.

Mockery Next requires a more logical way of specifying the modules you want to stub (https://github.com/mfncooper/mockery/pull/25/files). That's why the enormous changes to just filepaths in almost every test file.

lib/common/service.js

+
+  service[protoOpts.method](snakeize(reqOpts), function(err, resp) {
+    if (err) {
+      var HTTP_ERROR_CODE_MAP = {


callmehiphop · 2016-01-19T14:35:24Z

What are your thoughts on instead of adding conditionals to check whether or not we should be using grpc or request, we instead made additional classes that extend Service and ServiceObject? e.g. ProtoService and ProtoServiceObject.

If possible I think it might provide us with a cleaner separation of logic and potentially less of the actual service (in this case PubSub) would need to change.

Just throwing it out there, TBH I'm not even sure if it would work since I'm still going through the code. :)

stephenplusplus · 2016-01-19T14:43:46Z

That sounds good to me!

lib/pubsub/subscription.js

-    // out around 90 seconds. Allow an extra couple of seconds to give the API a
-    // chance to respond on its own before terminating the connection.
-    var PUBSUB_API_TIMEOUT = 90000;
-    this.timeout = PUBSUB_API_TIMEOUT + 2000;


stephenplusplus · 2016-01-19T21:13:52Z

@tbetbetbe - hello! I'm hoping you can take a look at how we're using gRPC here to make sure it's correct. I also have some general questions in my opening post for this PR that I could use some help with. Thanks, and if you have any questions, let me know!

stephenplusplus · 2016-01-22T16:13:36Z

@callmehiphop - ptal!

callmehiphop · 2016-01-22T16:22:57Z

@stephenplusplus LGTM!

lib/common/grpc-service.js

+    this.grpcCredentials
+  );
+
+  service[protoOpts.method](snakeize(reqOpts), function(err, resp) {


stephenplusplus · 2016-01-29T21:19:12Z

@murgatroid99 when I run our system tests, the output is pretty noisy:

  pubsub
D0129 16:18:20.158068000 123145305219072 frame_settings.c:243] adding 983041 for initial_window change
D0129 16:18:20.311131000 123145305219072 frame_settings.c:243] adding 983041 for initial_window change
D0129 16:18:20.358417000 123145306292224 frame_settings.c:243] adding 983041 for initial_window change
    Topic
D0129 16:18:21.339030000 123145304682496 frame_settings.c:243] adding 983041 for initial_window change
D0129 16:18:22.832881000 123145305219072 frame_settings.c:243] adding 983041 for initial_window change
D0129 16:18:23.626765000 123145305755648 frame_settings.c:243] adding 983041 for initial_window change

Is this something that can be switched off?

murgatroid99 · 2016-01-30T00:32:30Z

Those verbose logs shouldn't be output at all unless you have GRPC_TRACE=http or GRPC_TRACE=all in your environment.

stephenplusplus · 2016-01-30T00:37:40Z

I don't recall setting those. I echo'd and no value was returned, but unset just in case and still saw the logs.

stephenplusplus · 2016-02-02T16:10:25Z

@murgatroid99 I had a friend try and he ran into the same problem:

D0202 10:54:49.967704000 123145306595328 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.002932000 123145307668480 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.012918000 123145306595328 frame_settings.c:243] adding 983041 for initial_window change
    1) "before all" hook
D0202 10:54:50.235652000 123145307668480 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.270647000 123145307668480 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.286221000 123145306058752 frame_settings.c:243] adding 983041 for initial_window change

Should I open an issue on gRPC?

murgatroid99 · 2016-02-02T16:28:38Z

Yes, that would be helpful.

On Tue, Feb 2, 2016, 8:10 AM Stephen Sawchuk [email protected]
wrote:

@murgatroid99 https://github.com/murgatroid99 I had a friend try and he
ran into the same problem:

D0202 10:54:49.967704000 123145306595328 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.002932000 123145307668480 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.012918000 123145306595328 frame_settings.c:243] adding 983041 for initial_window change
1) "before all" hook
D0202 10:54:50.235652000 123145307668480 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.270647000 123145307668480 frame_settings.c:243] adding 983041 for initial_window change
D0202 10:54:50.286221000 123145306058752 frame_settings.c:243] adding 983041 for initial_window change

Should I open an issue on gRPC?

—
Reply to this email directly or view it on GitHub
#1070 (comment)
.

stephenplusplus · 2016-02-02T16:33:36Z

grpc/grpc#5004 -- sorry to increment a repo with already greater than 5000 issues :( Thanks for your help, though!

callmehiphop · 2016-02-11T16:49:43Z

I haven't been able to reproduce the IAM failures. Can you make sure to rm -rf node_modules && npm cache clean && npm install?

Still getting failures for this. Again, this doesn't look like a code issue, but rather the response for IAM comes back in object form vs strings for HTTP.

stephenplusplus · 2016-02-11T16:51:32Z

Can you paste the errors?

callmehiphop · 2016-02-11T16:53:42Z

pubsub IAM should get a policy:

  Uncaught AssertionError: { version: 0,
    bindings: [],
    etag: 
     { '0': 0,
       '1': 32,
       '2': 1,
       length: 3,
       parent: 'ewogICJwcml2YXRlX2t deepEqual { bindings: [], etag: 'ACAB', version: 0 }
  + expected - actual

   {
     "bindings": []
  -  "etag": {
  -    "0": 0
  -    "1": 32
  -    "2": 1
  -    "length": 3
  -    "parent": "{
  "private_key_id": "48f3201f204d0e54535b411405e1f47958690a87",
  "private_key": "-----BEGIN PRIVATE KEY-----\nMIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQCkJ81JtX9mqGp3\nywypGVU5A/wEjvlQnN7cJOHypxei9gSUhUJgc5dYdEg6h3NCZRThApxhknQHQoyE\ntpnrfpCwNl0r6w3yzuAaEo3mixxbrLFZBMYwGsVl7XgzvydEKJlUdgzw/b0Y73nZ\nCB8N4K7PlBNMIizgST8HCbjmq1PuylXr4xqan9NItukWsn+879N6QG/vFgqhAhU4\nMMmuX4foHCfVglGB3B+j1007bCztnHyLi4HvK+e8rMoEdzmy/6Mg5NtfyCDws1oB\nisul9QHtzu98qpaMcJZmtWkzDYOL/OGpJlbG4l8EGQraal9zz75s4oi4vteZ/LKF\nArqe9pC5AgMBAAECggEAGg6jXJbt4TrMo7Vcjh8SUxmZ0JNtaelsyt8j6qOxcdHB\nil3Y2nyewpC6wmer2Rc4iDsk3awktN5QdeSSbDpL91y5z3XhYfCKzDizw6vDVZ4F\nDM9gMlSdjv9x/CzUq9IR/ME8bqiocqPY4KWUYFyRAyxLH+Ow4e1ejtxxOFRr31SH\n2AvIYhPgSzURHy6SqG66Zkv9Rvhs5zgGtLPD43xTGcavqdRis5jUK0S0vVaIxe5W\no+C8rHwOhuB1jRo04kKWkce45WML+wIgzJl7Ut+gJ9tnUgychF5lay48ShMgMlPJ\n4LnjA/MEFdbxdsWig9VsA7W0DvCaoeomnFrZ560BAQKBgQDN7cOmUvKFfq+ibyuF\nNq4/Bqw66P3bPNlquxY/CkO5LeOoiIAEQBJ9+il7RVU6ZoLcTz+3FfP6UPvrDgn0\nZNfFcRnbADd3+IG6n8QVNfOBbq8N6bZwar2a51gwnVa7GbMGBvPAzF08jlDoX2i3\niL/WPt+Pesu6sEQaOYyM55HFIQKBgQDMEdGVQi7VLpGqNqHH7f7FxBAlGm2g0dCr\nKOg6SfBJIGZIUC6oTt2+AliAxwgnsd3WnVE3nJccq5MJARzgM/X9ObcZ8EmuQklm\nIApjJ4LXpbJSGLnc0vRry6iJEiXbrdD6HE9JFOyJq7jxo9qSJyg5QsNqhdBtAAvO\npFwpRh/AmQKBgQCwTE0C2OKODT56NuiwXHbiuGi86nlit35/VHogMD54i+Pqhinq\n+ZubRI883Mexfs+royEuMlo0xB5YRyWYmLjtbP2ws0fJqvQNfPgXHKBDACpYI+0v\n4wI+Wq7yt9Dnz4GnuE34kj2EOWbk+cGh1y49Uoh8wqkmQ/+Z4AkHHL18YQKBgQCP\nSPOfmZjIlqowmat+dd0tfzzW0HepM6kQhOiKBOByeA1ZOPOJudZ4U61Qvm87b+gT\niOI96fUwbEgRSna79cACzUODMvSJJoHi8xxYAqYcRHuwqSvXoUd9aMItfFCYrrLM\n6pPA/LAY+johcKtHc7cKfZY4dTyjTCT+MumDEXm6AQKBgDvI7KjEyNp2Eartc2db\n60O0rQea7HeNoLq8uQfuKSha8u5JS7L+qRiqTJ6II5hpt24bEMw8rdJUYY2rsH+N\np4wbFAZDDWtvhX7rDaNveJvsyOhof3N7RgCWXeLJD3nehyTNBs107L/eDx+YKVV7\nwPXGbDUuR8z88gtmkU9hSnwQ\n-----END PRIVATE KEY-----\n",
  "client_email": "806989004347-eor9d63e8ad1otbud07j57dnf2g1058l@developer.gserviceaccount.com",
  "client_id": "806989004347-eor9d63e8ad1otbud07j57dnf2g1058l.apps.googleusercontent.com",
  "type": "service_account"
}    {"alg":"RS256","typ":"JWT"}     {"iss":"806989004347-eor9d63e8ad1otbud07j57dnf2g1058l@developer.gserviceaccount.com","scope":"https://www.googleapis.com/auth/pubsub https://www.googleapis.com/auth/cloud-platform","aud":"https://accounts.google.com/o/oauth2/token","exp":1455212780,"iat":1455209180}      -----BEGIN PRIVATE KEY-----
MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQCkJ81JtX9mqGp3
ywypGVU5A/wEjvlQnN7cJOHypxei9gSUhUJgc5dYdEg6h3NCZRThApxhknQHQoyE
tpnrfpCwNl0r6w3yzuAaEo3mixxbrLFZBMYwGsVl7XgzvydEKJlUdgzw/b0Y73nZ
CB8N4K7PlBNMIizgST8HCbjmq1PuylXr4xqan9NItukWsn+879N6QG/vFgqhAhU4
MMmuX4foHCfVglGB3B+j1007bCztnHyLi4HvK+e8rMoEdzmy/6Mg5NtfyCDws1oB
isul9QHtzu98qpaMcJZmtWkzDYOL/OGpJlbG4l8EGQraal9zz75s4oi4vteZ/LKF
Arqe9pC5AgMBAAECggEAGg6jXJbt4TrMo7Vcjh8SUxmZ0JNtaelsyt8j6qOxcdHB
il3Y2nyewpC6wmer2Rc4iDsk3awktN5QdeSSbDpL91y5z3XhYfCKzDizw6vDVZ4F
DM9gMlSdjv9x/CzUq9IR/ME8bqiocqPY4KWUYFyRAyxLH+Ow4e1ejtxxOFRr31SH
2AvIYhPgSzURHy6SqG66Zkv9Rvhs5zgGtLPD43xTGcavqdRis5jUK0S0vVaIxe5W
o+C8rHwOhuB1jRo04kKWkce45WML+wIgzJl7Ut+gJ9tnUgychF5lay48ShMgMlPJ
4LnjA/MEFdbxdsWig9VsA7W0DvCaoeomnFrZ560BAQKBgQDN7cOmUvKFfq+ibyuF
Nq4/Bqw66P3bPNlquxY/CkO5LeOoiIAEQBJ9+il7RVU6ZoLcTz+3FfP6UPvrDgn0
ZNfFcRnbADd3+IG6n8QVNfOBbq8N6bZwar2a51gwnVa7GbMGBvPAzF08jlDoX2i3
iL/WPt+Pesu6sEQaOYyM55HFIQKBgQDMEdGVQi7VLpGqNqHH7f7FxBAlGm2g0dCr
KOg6SfBJIGZIUC6oTt2+AliAxwgnsd3WnVE3nJccq5MJARzgM/X9ObcZ8EmuQklm
IApjJ4LXpbJSGLnc0vRry6iJEiXbrdD6HE9JFOyJq7jxo9qSJyg5QsNqhdBtAAvO
pFwpRh/AmQKBgQCwTE0C2OKODT56NuiwXHbiuGi86nlit35/VHogMD54i+Pqhinq
+ZubRI883Mexfs+royEuMlo0xB5YRyWYmLjtbP2ws0fJqvQNfPgXHKBDACpYI+0v
4wI+Wq7yt9Dnz4GnuE34kj2EOWbk+cGh1y49Uoh8wqkmQ/+Z4AkHHL18YQKBgQCP
SPOfmZjIlqowmat+dd0tfzzW0HepM6kQhOiKBOByeA1ZOPOJudZ4U61Qvm87b+gT
iOI96fUwbEgRSna79cACzUODMvSJJoHi8xxYAqYcRHuwqSvXoUd9aMItfFCYrrLM
6pPA/LAY+johcKtHc7cKfZY4dTyjTCT+MumDEXm6AQKBgDvI7KjEyNp2Eartc2db
60O0rQea7HeNoLq8uQfuKSha8u5JS7L+qRiqTJ6II5hpt24bEMw8rdJUYY2rsH+N
p4wbFAZDDWtvhX7rDaNveJvsyOhof3N7RgCWXeLJD3nehyTNBs107L/eDx+YKVV7
wPXGbDUuR8z88gtmkU9hSnwQ
-----END PRIVATE KEY-----
grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Ajwt-bearer&assertion=eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiI4MDY5ODkwMDQzNDctZW9yOWQ2M2U4YWQxb3RidWQwN2o1N2RuZjJnMTA1OGxAZGV2ZWxvcGVyLmdzZXJ2aWNlYWNjb3VudC5jb20iLCJzY29wZSI6Imh0dHBzOi8vd3d3Lmdvb2dsZWFwaXMuY29tL2F1dGgvcHVic3ViIGh0dHBzOi8vd3d3Lmdvb2dsZWFwaXMuY29tL2F1dGgvY2xvdWQtcGxhdGZvcm0iLCJhdWQiOiJodHRwczovL2FjY291bnRzLmdvb2dsZS5jb20vby9vYXV0aDIvdG9rZW4iLCJleHAiOjE0NTUyMTI3ODAsImlhdCI6MTQ1NTIwOTE4MH0.d8QiYAQD8cFV52nzokw4pPFGgNMrJnnHlvo6RJI8oL8MVWW5spDIGsZzhx11zzIwVBWrTcJj7-Fk_S_w_JzvDHxyMV_HdF39hZYmJsBc6Aw5FOOJUPirWIemy86HddvhZ4oeeADUQX_oHgYw78ldh6wmw5afEEsBgbMwXJ5AifUBHM3BBt9vUmdUT-IvGsroaA9d836_ROccGnWkxI0ce-HTEa08nF6LuFGrlC2P1YwrVrANZxN2OTDp8JaqSpXnWeQLIJ3PVFBtQQuOiS-aJZh_VLlduTtkJXZSngTv2BJ9JmyqegrGGzCjoytHfpmNOyX0VRQmAlSQ-Wq0IV-ttg      {
  "access_token" : "ya29.hQKUi48vn3fsMzezuNInL9vadSGr-KmQpTTOkEYazkHn22rQ7f2LzK44fK4H9K3P-sHgriw",
  "token_type" : "Bearer",
  "expires_in" : 3600
} 
               
Rprojects/boreal-physics-911/topics/test-topic-b49963d9-92f0-4881-8ac6-041398265c0f    
Rprojects/boreal-physics-911/topics/test-topic-b49963d9-92f0-4881-8ac6-041398265c0f                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         "
  -  }
  +  "etag": "ACAB"
     "version": 0
   }

  at system-test/pubsub.js:364:16
  at lib/common/grpc-service.js:206:5

stephenplusplus · 2016-02-11T17:05:54Z

Confirmed on Node v0.12. This is an issue with GrpcService#isBufferLike_ -- I'll see if I can find a fix!

stephenplusplus · 2016-02-11T17:13:48Z

Fixed in stephenplusplus@7811c4f - ptal

callmehiphop · 2016-02-11T19:30:03Z

@stephenplusplus looks like Travis is still choking on it

stephenplusplus · 2016-02-11T19:57:51Z

Travis has been put in his place.

callmehiphop · 2016-02-12T16:10:38Z

@stephenplusplus LGTM, let me know if there's anything else I can do to help.

stephenplusplus · 2016-02-12T16:15:18Z

Cool, thanks!

@tmatsuo is gRPC generally available for pubsub.googleapis.com?

stephenplusplus · 2016-02-16T15:08:20Z

@callmehiphop this thing is ready to fly.

lib/common/grpc-service.js

+ */
+GrpcService.prototype.request = function(protoOpts, reqOpts, callback) {
+  if (global.GCLOUD_TEST_ENVIRONMENT) {
+    return global.GCLOUD_TEST_ENVIRONMENT;


pubsub: convert to grpc

callmehiphop · 2016-02-16T18:17:35Z

This restores the fix from googleapis#1105 which was broken after googleapis#1070

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/compatibility-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/confidence-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-vision).

stephenplusplus added api: pubsub Issues related to the Pub/Sub API. core labels Jan 19, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2016

callmehiphop reviewed Jan 19, 2016
View reviewed changes

stephenplusplus force-pushed the spp--grpc-rpc branch 2 times, most recently from 3dd733d to 28dbca2 Compare January 22, 2016 16:12

stephenplusplus reviewed Jan 22, 2016
View reviewed changes

stephenplusplus added the don't merge label Jan 26, 2016

stephenplusplus mentioned this pull request Jan 29, 2016

(Node.js) Usage Questions grpc/grpc#4962

Closed

stephenplusplus force-pushed the spp--grpc-rpc branch from 28dbca2 to 9cf1626 Compare January 29, 2016 21:20

stephenplusplus mentioned this pull request Feb 2, 2016

Node.js: Forced debug logging grpc/grpc#5004

Closed

This was referenced Feb 2, 2016

Node.js: Convert snake_case to camelCase grpc/grpc#5005

Closed

Node.js: Allow switching on buffer conversions grpc/grpc#5006

Closed

stephenplusplus force-pushed the spp--grpc-rpc branch 3 times, most recently from 3a5a790 to 625b767 Compare February 4, 2016 17:42

stephenplusplus added the don't merge label Feb 11, 2016

stephenplusplus force-pushed the spp--grpc-rpc branch 2 times, most recently from 56729ff to e904058 Compare February 12, 2016 01:54

stephenplusplus force-pushed the spp--grpc-rpc branch from e904058 to 4825ecd Compare February 12, 2016 16:14

stephenplusplus force-pushed the spp--grpc-rpc branch from 4825ecd to 6243407 Compare February 16, 2016 15:00

stephenplusplus removed the don't merge label Feb 16, 2016

stephenplusplus mentioned this pull request Feb 16, 2016

Move proto-compatible APIs to grpc #1049

Closed

3 tasks

stephenplusplus added the minor label Feb 16, 2016

callmehiphop reviewed Feb 16, 2016
View reviewed changes

stephenplusplus force-pushed the spp--grpc-rpc branch from 6243407 to 377439d Compare February 16, 2016 17:26

implement gRPC support

1bcc94d

pubsub: convert to grpc

stephenplusplus force-pushed the spp--grpc-rpc branch from 377439d to 1bcc94d Compare February 16, 2016 17:26

callmehiphop added a commit that referenced this pull request Feb 16, 2016

Merge pull request #1070 from stephenplusplus/spp--grpc-rpc

1962cc8

pubsub: convert to grpc

callmehiphop merged commit 1962cc8 into googleapis:master Feb 16, 2016

ctavan added a commit to ctavan/google-cloud-node that referenced this pull request Feb 3, 2017

pubsub: Fix broken abortion of outstanding requests

2d6a54d

This restores the fix from googleapis#1105 which was broken after googleapis#1070

ctavan mentioned this pull request Feb 3, 2017

pubsub: Fix broken abortion of outstanding requests #1961

Closed

ctavan added a commit to ctavan/google-cloud-node that referenced this pull request Feb 3, 2017

pubsub: Fix broken abortion of outstanding requests

72129dd

This restores the fix from googleapis#1105 which was broken after googleapis#1070

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

pubsub: convert to grpc #1070

pubsub: convert to grpc #1070

Conversation

stephenplusplus commented Jan 19, 2016

To Dos

mockery -> mockery-next

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

callmehiphop commented Jan 19, 2016

stephenplusplus commented Jan 19, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Jan 19, 2016

stephenplusplus commented Jan 22, 2016

callmehiphop commented Jan 22, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Jan 29, 2016

murgatroid99 commented Jan 30, 2016

stephenplusplus commented Jan 30, 2016

stephenplusplus commented Feb 2, 2016

murgatroid99 commented Feb 2, 2016

stephenplusplus commented Feb 2, 2016

callmehiphop commented Feb 11, 2016

stephenplusplus commented Feb 11, 2016

callmehiphop commented Feb 11, 2016

stephenplusplus commented Feb 11, 2016

stephenplusplus commented Feb 11, 2016

callmehiphop commented Feb 11, 2016

stephenplusplus commented Feb 11, 2016

callmehiphop commented Feb 12, 2016

stephenplusplus commented Feb 12, 2016

stephenplusplus commented Feb 16, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

callmehiphop commented Feb 16, 2016

`mockery` -> `mockery-next`