datastore/request: add API error handling #153

proppy · 2014-08-29T22:57:23Z

When HTTP response are != from 200 we shouldn't try to decode a protobuf.

lib/datastore/transaction.js

@@ -446,7 +446,15 @@ Transaction.prototype.makeReq = function(method, req, respType, callback) {
        buffer = Buffer.concat([buffer, chunk]);
      });
      resp.on('end', function() {
-        callback(null, respType.decode(buffer));
+        if (resp.statusCode != 200) {


rakyll · 2014-08-29T23:05:28Z

npm run lint to lint your code.

ryanseys · 2014-08-29T23:08:54Z

Silly question but is the response guaranteed to not be a decodable
protobuf if an error occurs? Or is the response always null/nothing if
error has a value?

On Friday, August 29, 2014, Johan Euphrosine [email protected]
wrote:

When HTTP response are != from 200 we shouldn't try to decode a protobuf.

You can merge this Pull Request by running

git pull https://github.com/proppy/gcloud-node add-error-handling

Or view, comment on, or merge it at:

#153
Commit Summary

datastore/request: add API error handling

File Changes

M lib/datastore/transaction.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/153/files#diff-0
(10)

Patch Links:

https://github.com/GoogleCloudPlatform/gcloud-node/pull/153.patch

https://github.com/GoogleCloudPlatform/gcloud-node/pull/153.diff

—
Reply to this email directly or view it on GitHub
#153.

proppy · 2014-08-29T23:12:51Z

@ryanseys in case of an error the body should be JSON in the standard Google API format (with an error attribute).

proppy · 2014-08-29T23:43:39Z

PTAL

lib/datastore/transaction.js

+            callback(err);
+            return;
+          }
+          return callback(null, respType.decode(buffer));        


proppy · 2014-08-30T00:22:48Z

PTAL

rakyll · 2014-08-30T00:24:25Z

Tests are failing.

proppy · 2014-08-30T00:29:00Z

Fixed, PTAL

datastore/request: add API error handling

lib/common/util.js

-    callback(new Error('error during request, statusCode: ' + resp.statusCode));
+    var error = 'error during request, statusCode: ' + resp.statusCode;
+    if (body) {
+      error += ', body: ' + body;


This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://togithub.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://togithub.com/boneskull)) ### [`v8.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://togithub.com/giltayar) and [**@nicojs**](https://togithub.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://togithub.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://togithub.com/UlisesGascon)) - [#4175](https://togithub.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://togithub.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://togithub.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://togithub.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://togithub.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://togithub.com/juergba)) - [#4282](https://togithub.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://togithub.com/arvidOtt)) - [#4223](https://togithub.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://togithub.com/juergba)) - [#4178](https://togithub.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://togithub.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://togithub.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://togithub.com/boneskull)) ❗ See also [#4244](https://togithub.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://togithub.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://togithub.com/JacobLey)) - [#4299](https://togithub.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://togithub.com/giltayar)) #### 📖 Documentation - [#4246](https://togithub.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://togithub.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-phishing-protection).

* chore: migrate to owl bot * chore: copy files from googleapis-gen fb91803ccef5d7c695139b22788b309e2197856b * chore: run the post processor * 🦉 Updates from OwlBot * fix: help tests pass * 🦉 Updates from OwlBot * update Docker image * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]>

* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/nodejs-binary-authorization@v1.5.1...v2.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * make v1 default service version (#139) * update library to use Node 12 (#153) ### Features * Adds a pod_namespace field to pod events created by Continuous Validation, to distinguish pods with the same name that run in different namespaces ([#159](googleapis/nodejs-binary-authorization#159)) ([db983a2](googleapis/nodejs-binary-authorization@db983a2)) * Import of Grafeas from Github ([#156](googleapis/nodejs-binary-authorization#156)) ([d0f06b7](googleapis/nodejs-binary-authorization@d0f06b7)) * make v1 default service version ([#139](googleapis/nodejs-binary-authorization#139)) ([308286e](googleapis/nodejs-binary-authorization@308286e)) ### Bug Fixes * **docs:** describe fallback rest option ([#160](googleapis/nodejs-binary-authorization#160)) ([dc48528](googleapis/nodejs-binary-authorization@dc48528)) ### Build System * update library to use Node 12 ([#153](googleapis/nodejs-binary-authorization#153)) ([cafc43b](googleapis/nodejs-binary-authorization@cafc43b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-loader](https://togithub.com/TypeStrong/ts-loader) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/ts-loader/8.1.0/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/compatibility-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/confidence-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v9.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v900) [Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v8.1.0...v9.0.0) Breaking changes: - minimum webpack version: 5 - minimum node version: 12 Changes: - [webpack 5 migration](https://togithub.com/TypeStrong/ts-loader/pull/1251) - thanks [@johnnyreilly](https://togithub.com/johnnyreilly), [@jonwallsten](https://togithub.com/jonwallsten), [@sokra](https://togithub.com/sokra), [@appzuka](https://togithub.com/appzuka), [@alexander-akait](https://togithub.com/alexander-akait) </details> --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-bigquery-storage).

* chore(main): release 2.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 2.1.3 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

🤖 I have created a release \*beep\* \*boop\* --- ### [1.7.2](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.7.1...v1.7.2) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#152](https://www.github.com/googleapis/nodejs-ai-platform/issues/152)) ([96b9fba](https://www.github.com/googleapis/nodejs-ai-platform/commit/96b9fba9b66807ac5ea2c5826d5fd3f4e895dc9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Release @google-cloud/automl v0.2.0 This pull request was generated using releasetool. #153 automerged by dpebot

datastore/request: add API error handling

3e759bd

rakyll reviewed Aug 29, 2014
View reviewed changes

proppy added 2 commits August 29, 2014 16:42

datastore/request: handle API response with util.handleResp

53d0599

common/util: lint

ba49f39

rakyll reviewed Aug 30, 2014
View reviewed changes

lib/datastore/transaction.js

callback(err);

return;

}

return callback(null, respType.decode(buffer));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

datastore/request: remove useless return

7537fd5

common/util/handleResp: only add body when non null

f06a4b1

rakyll pushed a commit that referenced this pull request Aug 30, 2014

Merge pull request #153 from proppy/add-error-handling

d539bf0

datastore/request: add API error handling

rakyll merged commit d539bf0 into googleapis:master Aug 30, 2014

rakyll reviewed Aug 30, 2014
View reviewed changes

lib/common/util.js

callback(new Error('error during request, statusCode: ' + resp.statusCode));

var error = 'error during request, statusCode: ' + resp.statusCode;

if (body) {

error += ', body: ' + body;

This comment was marked as spam.

Sign in to view

snyk-bot mentioned this pull request May 21, 2020

[Snyk] Upgrade google-proto-files from 0.1.1 to 0.20.0 aknuds1/gcloud-node#1

Open

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

fix(deps): update dependency google-gax to ^0.26.0 (#153)

892d456

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-game-servers #3569

Merged

migrate code from googleapis/nodejs-video-transcoder #3571

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs(nodejs): version support policy edits (#1346) (#153)

11162d2

sofisl added a commit that referenced this pull request Nov 11, 2022

build!: update library to use Node 12 (#153)

a754fda

* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-binary-authorization #3576

Merged

migrate code from googleapis/nodejs-bigquery-storage #3599

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-kms #3601

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency eslint-plugin-node to v9 (#153)

4f1eb36

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-appengine-admin #3607

Merged

4 tasks

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-managed-identities #3642

Merged

4 tasks

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

sofisl pushed a commit that referenced this pull request Nov 17, 2022

Enable no-var in eslint (#153)

60d8205

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 30, 2022

chore: remove tslint.json (#153)

156675a

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

feat: add CloudStorageRegexFileSet (#153)

8f6025a

sofisl pushed a commit that referenced this pull request Jan 24, 2023

chore(deps): update dependency nyc to v13 (#153)

dffa3bb

sofisl pushed a commit that referenced this pull request Jan 25, 2023

chore(deps): update dependency nyc to v13 (#153)

d554141

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

Release @google-cloud/automl v0.2.0

6f3a8e8

Release @google-cloud/automl v0.2.0 This pull request was generated using releasetool. #153 automerged by dpebot

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore/request: add API error handling #153

datastore/request: add API error handling #153

proppy commented Aug 29, 2014

This comment was marked as spam.

rakyll commented Aug 29, 2014

ryanseys commented Aug 29, 2014

When HTTP response are != from 200 we shouldn't try to decode a protobuf.

proppy commented Aug 29, 2014

proppy commented Aug 29, 2014

This comment was marked as spam.

This comment was marked as spam.

proppy commented Aug 30, 2014

rakyll commented Aug 30, 2014

proppy commented Aug 30, 2014

This comment was marked as spam.

datastore/request: add API error handling #153

datastore/request: add API error handling #153

Conversation

proppy commented Aug 29, 2014

This comment was marked as spam.

rakyll commented Aug 29, 2014

ryanseys commented Aug 29, 2014

When HTTP response are != from 200 we shouldn't try to decode a protobuf.

proppy commented Aug 29, 2014

proppy commented Aug 29, 2014

This comment was marked as spam.

This comment was marked as spam.

proppy commented Aug 30, 2014

rakyll commented Aug 30, 2014

proppy commented Aug 30, 2014

This comment was marked as spam.