Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-grpc: correctly define default service options #2192

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

stephenplusplus
Copy link
Contributor

Fixes #2190

According to this comment, I was improperly defining gRPC default options.

@murgatroid99 does this look better? Thanks!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2017
@stephenplusplus stephenplusplus added core and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 7, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5dc78ca on stephenplusplus:spp--2190 into aa9525d on GoogleCloudPlatform:master.

@murgatroid99
Copy link

I think this should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants