chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
feat: added ImageQualityScores message to document.proto feat: added PropertyMetadata and EntityTypeMetadata to document_schema.proto PiperOrigin-RevId: 486975621 Source-Link: googleapis/googleapis@398c9f9 Source-Link: googleapis/googleapis-gen@7cd1f5f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbnRlbnR3YXJlaG91c2UvLk93bEJvdC55YW1sIiwiaCI6IjdjZDFmNWY0ZTQzNTc3N2NiODI0YWYyNjhkYzhkMzcxMzQ2MTNlNmEifQ==
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
|
/gcbrun |
|
/gcbrun |
PiperOrigin-RevId: 487258346 Source-Link: googleapis/googleapis@6e1a5a0 Source-Link: googleapis/googleapis-gen@966c9cd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbnRlbnR3YXJlaG91c2UvLk93bEJvdC55YW1sIiwiaCI6Ijk2NmM5Y2Q4OWI2NWU4MTMyYzA4NzM0NDg4M2QwMmI3ODhjMTM3YTAifQ==
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
sofisl
approved these changes
Nov 10, 2022
|
/gcbrun |
…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java) PiperOrigin-RevId: 493113566 Source-Link: googleapis/googleapis@758f0d1 Source-Link: googleapis/googleapis-gen@78bd8f0 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbnRlbnR3YXJlaG91c2UvLk93bEJvdC55YW1sIiwiaCI6Ijc4YmQ4ZjA1ZTEyNzYzNjNlYjE0ZWFlNzBlOTFmZTRiYzIwNzAzYWIifQ==
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566
Source-Link: googleapis/googleapis@758f0d1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbnRlbnR3YXJlaG91c2UvLk93bEJvdC55YW1sIiwiaCI6Ijc4YmQ4ZjA1ZTEyNzYzNjNlYjE0ZWFlNzBlOTFmZTRiYzIwNzAzYWIifQ==
BEGIN_NESTED_COMMIT
docs: fix minor docstring formatting
PiperOrigin-RevId: 487258346
Source-Link: googleapis/googleapis@6e1a5a0
Source-Link: https://github.com/googleapis/googleapis-gen/commit/966c9cd89b65e8132c087344883d02b788c137a0
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbnRlbnR3YXJlaG91c2UvLk93bEJvdC55YW1sIiwiaCI6Ijk2NmM5Y2Q4OWI2NWU4MTMyYzA4NzM0NDg4M2QwMmI3ODhjMTM3YTAifQ==
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: added font_family to document.proto
feat: added ImageQualityScores message to document.proto
feat: added PropertyMetadata and EntityTypeMetadata to document_schema.proto
PiperOrigin-RevId: 486975621
Source-Link: googleapis/googleapis@398c9f9
Source-Link: https://github.com/googleapis/googleapis-gen/commit/7cd1f5f4e435777cb824af268dc8d37134613e6a
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbnRlbnR3YXJlaG91c2UvLk93bEJvdC55YW1sIiwiaCI6IjdjZDFmNWY0ZTQzNTc3N2NiODI0YWYyNjhkYzhkMzcxMzQ2MTNlNmEifQ==
END_NESTED_COMMIT