Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: grab latest version of cloudrad #3677

Merged
merged 3 commits into from
Nov 30, 2022
Merged

build: grab latest version of cloudrad #3677

merged 3 commits into from
Nov 30, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Nov 22, 2022

No description provided.

@sofisl sofisl requested a review from a team as a code owner November 22, 2022 18:59
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@@ -21,4 +21,4 @@ set -eo pipefail
npm install

# publish docs to devsite
npx @google-cloud/cloud-rad@0.2.5
npx @google-cloud/cloud-rad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
npx @google-cloud/cloud-rad
npx @google-cloud/cloud-rad@0.2.18

Copy link
Contributor

@dansaadati dansaadati Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just published latest: npx @google-cloud/[email protected]. Will need to get autorelease going for the package!

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would still be good to pin to a version of @google-cloud/cloud-rad, otherwise if there are major changes to cloud-rad in the future our builds will break.

Copy link
Contributor

@dansaadati dansaadati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@sofisl sofisl requested a review from bcoe November 22, 2022 19:29
@sofisl sofisl merged commit c8bc63b into main Nov 30, 2022
@sofisl sofisl deleted the sofisl-patch-3 branch November 30, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants