Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MultiRegional and Regional to Standard #9191

Closed
JesseLovelace opened this issue Sep 9, 2019 · 0 comments · Fixed by #9205
Closed

Update MultiRegional and Regional to Standard #9191

JesseLovelace opened this issue Sep 9, 2019 · 0 comments · Fixed by #9205
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@JesseLovelace
Copy link
Contributor

Previously, we implemented the concept of "Location Type" to move the concept of bucket location away from storage class. It is no longer considered correct to use "MultiRegional" or "Regional" as a storage class, instead those should be location types.

As such, we need to update every instance of the "MultiRegional" and "Regional" storage in samples, library documentation, and tests to use "Standard" instead--Standard is a correct storage class.

Note that "MultiRegional" and "Regional" should only be replaced with "Standard" in cases where they are used a storage class. If they're used as a location type, that's fine and doesn't need to be replaced.

https://github.com/googleapis/google-cloud-python/blob/ae2e7058e402c4c963bc4991af7cd5f2b2801cc9/storage/tests/unit/test_bucket.py

storage_class = "MULTI_REGIONAL"

self.assertEqual(conditions.matches_storage_class, ["REGIONAL"])

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/03e47889042b52ebb2610c5ba19a23bebb39a497/notebooks/rendered/storage-command-line-tool.md#L73
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/03e47889042b52ebb2610c5ba19a23bebb39a497/notebooks/tutorials/storage/Storage%20command-line%20tool.ipynb#L141

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like. type: cleanup An internal cleanup or hygiene concern. and removed type: process A process-related concern. May include testing, release, or the like. labels Sep 9, 2019
tseaver added a commit that referenced this issue Sep 16, 2019
Move storage class / location type constants to a new module.

Exceptions are for setters, which test allowed values.

Closes #9191.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this issue Sep 18, 2019
…apis#9205)

Move storage class / location type constants to a new module.

Exceptions are for setters, which test allowed values.

Closes googleapis#9191.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this issue Sep 18, 2019
…apis#9205)

Move storage class / location type constants to a new module.

Exceptions are for setters, which test allowed values.

Closes googleapis#9191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants