Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added first draft of dns design doc. #92

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions gcloud/datastore/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from gcloud.datastore.key import Key

INT64 = Int64ValueChecker().CheckValue
check_int64_value = Int64ValueChecker().CheckValue


def get_protobuf_attribute_and_value(val):
Expand Down Expand Up @@ -56,7 +56,8 @@ def get_protobuf_attribute_and_value(val):
elif isinstance(val, float):
name, value = 'double', val
elif isinstance(val, (int, long)):
name, value = 'integer', INT64(val)
check_int64_value(val) # This will raise an exception if invalid.
name, value = 'integer', val
elif isinstance(val, basestring):
name, value = 'string', val

Expand Down