Upgrade Rubocop #1923

blowmage · 2018-01-11T22:32:19Z

This PR upgrades the dependency on Rubocop, updates the code match the most recent style guide, and removes unnecessary configuration and fixes configuration warnings in the individual gems' .rubocop.yml files.

[fixes #1838]

Changes needed to adhere to updated style guide in latest Rubocop.

The Firestore credentials class should have been made public before releasing. Update the documentation to reflect that it is public. Add a default file path for gcloud SDK credentials.

Changes needed to adhere to updated style guide in latest Rubocop.

Remove pinned rainbow dependency since Rubocop needs updated version.

Downgrade to the last version that supported Ruby 2.0. This version is recent enough to satisfy security warnings.

blowmage · 2018-01-12T09:03:59Z

@quartzmo @dazuma This PR has a large surface area. I'd like to minimize any future conflicts by merging this ASAP, before other PRs add code that don't adhere to the upgraded style guide. Can you review this as soon as you are able?

blowmage · 2018-01-12T09:05:32Z

@geigerj This PR has several changes for the updated style guide that may affect how the GAPIC files are generated for new gems. Happy to discuss these changes with you.

google-cloud-bigquery/lib/google/cloud/bigquery/dataset.rb

@@ -1601,7 +1603,7 @@ def reload!
          @gapi = reloaded_gapi
          self
        end
-        alias_method :refresh!, :reload!
+        alias refresh! reload!


google-cloud-bigquery/lib/google/cloud/bigquery/external.rb

-                  "bigtable"               => "BIGTABLE"
-                }[format.to_s.downcase]
+          val = {
+            "csv" => "CSV",          "avro" => "AVRO",


google-cloud-bigquery/lib/google/cloud/bigquery/table.rb

@@ -211,13 +211,12 @@ def time_partitioning_type
        #
        def time_partitioning_type= type
          reload! unless resource_full?
-          @gapi.time_partitioning ||=
-              Google::Apis::BigqueryV2::TimePartitioning.new
+          @gapi.time_partitioning ||= \


Gemfile

@@ -6,7 +6,7 @@ gem "minitest-autotest", "~> 1.0"
 gem "minitest-focus", "~> 1.1"
 gem "minitest-rg", "~> 5.2"
 gem "autotest-suffix", "~> 1.1"
-gem "rubocop", "<= 0.35.1"
+gem "rubocop", "~> 0.50.0"


dazuma · 2018-01-12T18:25:37Z

My vague recollection was that we had pinned Rubocop to an early version because newer versions drop support for certain older versions of Ruby that we still support. I'd be happy to be misremembering, though. (Maybe I'm thinking about a different gem?) Just wanted to make sure we still work with all the Ruby versions we support.

blowmage · 2018-01-12T18:41:07Z

We originally pinned Rubocop because 0.36.0 was released and made massive changes to the style guide and every gem build broke because of it. The upgrade to 0.50 (and 0.52), while intensive, was much simpler than the upgrade to 0.36 would have been. But that's why we originally pinned the dependency.

blowmage · 2018-01-12T18:47:32Z

All in all, while I believe in keeping on the technology treadmill, I find the churn in Rubocop's style guide to be frustrating. I've been very happy to stay on one style guide for a longer period of time, rather than upgrading every time a new Rubocop version is released. But will concede that an entire year between updating the style guide may be too long.

gcloud/Gemfile

 gem "google-cloud-bigquery", path: "../google-cloud-bigquery"
+gem "google-cloud-container", path: "../google-cloud-container"


google-cloud/Gemfile

 gem "google-cloud-bigquery", path: "../google-cloud-bigquery"
+gem "google-cloud-container", path: "../google-cloud-container"


google-cloud-trace/lib/google/cloud/trace/faraday_middleware.rb

@@ -68,7 +68,7 @@ def add_response_labels span, env
                    response_body.bytesize.to_s
          set_label labels, label_keys::HTTP_STATUS_CODE, response_status.to_s

-          if 300 <= response_status && response_status < 400 && response_url
+          if response_status >= 300 && response_status < 400 && response_url


quartzmo

@blowmage Thank you for taking this on, it must have been a maddening task! I especially appreciate how you removed the unneeded rubocop overrides that resulted from copy/pasting .rubocop.yml. Great work!

blowmage · 2018-01-12T20:14:49Z

@dazuma Do you have any concerns? I'd like to get this merged ASAP.

dazuma

No other questions. LGTM. Thanks for doing this!

blowmage added 29 commits January 11, 2018 15:27

Bump Rubocop to recent version

60e3d01

Update Storage code style

403ac38

Changes needed to adhere to updated style guide in latest Rubocop.

Update Speech code style

5ef3f74

Changes needed to adhere to updated style guide in latest Rubocop.

Update Spanner code style

956fa3c

Changes needed to adhere to updated style guide in latest Rubocop.

Update Trace code style

cefa584

Changes needed to adhere to updated style guide in latest Rubocop.

Update Translate code style

8dd4098

Changes needed to adhere to updated style guide in latest Rubocop.

Update Video Intelligence code style

8d94fdc

Changes needed to adhere to updated style guide in latest Rubocop.

Update Vision code style

10b3447

Changes needed to adhere to updated style guide in latest Rubocop.

Update BigQuery code style

c9d1f7f

Changes needed to adhere to updated style guide in latest Rubocop.

Update Bigtable code style

e8929d4

Changes needed to adhere to updated style guide in latest Rubocop.

Update Container code style

5e0acb2

Changes needed to adhere to updated style guide in latest Rubocop.

Update google-cloud-core code style

7a620c0

Changes needed to adhere to updated style guide in latest Rubocop.

Update Dataproc code style

7e1c0d8

Changes needed to adhere to updated style guide in latest Rubocop.

Update Datastore code style

22d5aed

Changes needed to adhere to updated style guide in latest Rubocop.

Update Debugger code style

69cbcfe

Changes needed to adhere to updated style guide in latest Rubocop.

Update DLP code style

dbe1b08

Changes needed to adhere to updated style guide in latest Rubocop.

Update DNS code style

5aa74e7

Changes needed to adhere to updated style guide in latest Rubocop.

Update google-cloud-env code style

b19c467

Changes needed to adhere to updated style guide in latest Rubocop.

Update Error Reporting code style

675303c

Changes needed to adhere to updated style guide in latest Rubocop.

Update Firestore code style

d0c9d4a

Changes needed to adhere to updated style guide in latest Rubocop.

Add Firestore Credentials to Public API

655ab22

The Firestore credentials class should have been made public before releasing. Update the documentation to reflect that it is public. Add a default file path for gcloud SDK credentials.

Update Natural Language code style

5e0c2d2

Changes needed to adhere to updated style guide in latest Rubocop.

Update Stackdriver Logging code style

135de4a

Changes needed to adhere to updated style guide in latest Rubocop.

Update Stackdriver Monitoring code style

192f7bd

Changes needed to adhere to updated style guide in latest Rubocop.

Update OS Login code style

11f0288

Changes needed to adhere to updated style guide in latest Rubocop.

Update Pub/Sub code style

b4b53e5

Changes needed to adhere to updated style guide in latest Rubocop.

Update Resource Manager code style

d6c5a97

Changes needed to adhere to updated style guide in latest Rubocop.

Update google-cloud code style

c236a78

Changes needed to adhere to updated style guide in latest Rubocop.

Update gcloud code style

d797edd

Changes needed to adhere to updated style guide in latest Rubocop.

blowmage added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jan 11, 2018

blowmage added the api: oslogin Issues related to the Cloud OS Login API API. label Jan 11, 2018

blowmage self-assigned this Jan 11, 2018

blowmage requested review from dazuma, quartzmo and geigerj January 11, 2018 22:32

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018

blowmage added 2 commits January 11, 2018 17:06

Update stackdriver-core code style

154bb77

Changes needed to adhere to updated style guide in latest Rubocop.

Update stackdriver code style

b1d7bf1

Changes needed to adhere to updated style guide in latest Rubocop.

blowmage force-pushed the rubocop-upgrade branch 5 times, most recently from 65201ef to 0ef8195 Compare January 12, 2018 04:10

blowmage added 2 commits January 11, 2018 21:56

Update top-level Gemfile

33b9940

Remove pinned rainbow dependency since Rubocop needs updated version.

Downgrade Rubocop

3d120de

Downgrade to the last version that supported Ruby 2.0. This version is recent enough to satisfy security warnings.

blowmage force-pushed the rubocop-upgrade branch from 0ef8195 to 3d120de Compare January 12, 2018 04:57

dazuma reviewed Jan 12, 2018

View reviewed changes

quartzmo reviewed Jan 12, 2018

View reviewed changes

google-cloud/Gemfile

gem "google-cloud-bigquery", path: "../google-cloud-bigquery"

gem "google-cloud-container", path: "../google-cloud-container"

This comment was marked as spam.

Sign in to view

quartzmo reviewed Jan 12, 2018

View reviewed changes

quartzmo approved these changes Jan 12, 2018

View reviewed changes

dazuma approved these changes Jan 12, 2018

View reviewed changes

blowmage merged commit 874c529 into googleapis:master Jan 12, 2018

blowmage mentioned this pull request Mar 28, 2019

Can not obtain a signed url for a file with a space in its name #3064

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Rubocop #1923

Upgrade Rubocop #1923

blowmage commented Jan 11, 2018 •

edited

Loading

blowmage commented Jan 12, 2018

blowmage commented Jan 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dazuma commented Jan 12, 2018

blowmage commented Jan 12, 2018

blowmage commented Jan 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

quartzmo left a comment

blowmage commented Jan 12, 2018

dazuma left a comment

		gem "google-cloud-bigquery", path: "../google-cloud-bigquery"
		gem "google-cloud-container", path: "../google-cloud-container"

Upgrade Rubocop #1923

Upgrade Rubocop #1923

Conversation

blowmage commented Jan 11, 2018 • edited Loading

blowmage commented Jan 12, 2018

blowmage commented Jan 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dazuma commented Jan 12, 2018

blowmage commented Jan 12, 2018

blowmage commented Jan 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

quartzmo left a comment

Choose a reason for hiding this comment

blowmage commented Jan 12, 2018

dazuma left a comment

Choose a reason for hiding this comment

blowmage commented Jan 11, 2018 •

edited

Loading