-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): load jobs with dest tables in another project #27681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
Issues related to the BigQuery API.
label
Nov 27, 2024
quartzmo
reviewed
Nov 27, 2024
quartzmo
approved these changes
Nov 27, 2024
alvarowolfx
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 29, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 29, 2024
blocked by #27684 |
dazuma
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks much!
shubhangi-google
pushed a commit
to shubhangi-google/google-cloud-ruby
that referenced
this pull request
Dec 11, 2024
This was referenced Dec 11, 2024
aandreassa
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR favors the usage of the
dataset.project_id
method instead of@service.project
to allow Load jobs to target tables in a dataset that lives in a separated project, other than the project usage on the main client and which is used for billing.A follow up PR needs to be address more scenarios where we should favor that same usage of the
dataset.project_id
instead of@service.project
, since is a common use case where operations are run in project A to modify data stored in project B.I haven't added integration tests, since we would not have write access to two different projects in our CI pipelines. But I tested locally with this given code:
Fixes #27368