Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatic kokoro label in addition to /gcbrun comment #2233

Merged
merged 1 commit into from
May 29, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented May 14, 2024

From reading the configuration (https://github.com/googleapis/repo-automation-bots/pull/1682/files), it accepts multiple objects.

@suztomo suztomo requested review from a team as code owners May 14, 2024 19:02
Copy link

Warning: This pull request is touching the following templated files:

  • .github/trusted-contribution.yml

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels May 14, 2024
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label May 14, 2024
kolea2
kolea2 previously approved these changes May 14, 2024
@kolea2 kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label May 14, 2024
@kolea2
Copy link
Contributor

kolea2 commented May 14, 2024

@kolea2 kolea2 dismissed their stale review May 14, 2024 22:34

question asked

@suztomo
Copy link
Member Author

suztomo commented May 14, 2024

Yes, that's nice idea after we confirm this change works as expected here.

@suztomo
Copy link
Member Author

suztomo commented May 15, 2024

Pull request there is ready googleapis/synthtool#1965 when we confirm the options work well in this repository.

@suztomo suztomo merged commit 987738f into main May 29, 2024
23 checks passed
@suztomo suztomo deleted the suztomo-patch-1 branch May 29, 2024 17:57
@suztomo
Copy link
Member Author

suztomo commented Jun 3, 2024

It worked well.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants