Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include metric name in error message #2412

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: include metric name in error message #2412

merged 1 commit into from
Nov 13, 2024

Conversation

igorbernstein2
Copy link
Contributor

Change-Id: I8e7578fa4c5af6e8dcde04201ec7d6aa9c8f8762

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Change-Id: I8e7578fa4c5af6e8dcde04201ec7d6aa9c8f8762
@igorbernstein2 igorbernstein2 requested review from a team as code owners November 13, 2024 19:25
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 13, 2024
@mutianf mutianf changed the title core: include metric name in error message chore: include metric name in error message Nov 13, 2024
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2024
@mutianf mutianf merged commit 158185f into main Nov 13, 2024
23 checks passed
@mutianf mutianf deleted the metric-error branch November 13, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants