Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new stages. #1908

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Implement new stages. #1908

merged 7 commits into from
Nov 4, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Oct 28, 2024 •
edited
Loading

Implement stages:

  • Replace
  • Sample
  • Union
  • Unnest

Remove Fields class, since having Selectable an array of fields won't work for all stages. The unnest stage cannot support this, so this construct will cause problems.

Some refactors.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/java-firestore API. labels Oct 28, 2024
@tom-andersen tom-andersen marked this pull request as ready for review October 28, 2024 15:42
@tom-andersen tom-andersen requested review from a team as code owners October 28, 2024 15:42
@tom-andersen
Merge remote-tracking branch 'origin/wuandy/JavaPplPP' into tomanders…
8f9d2c8 
…en/ppNewFunctions

# Conflicts:
#	google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
@tom-andersen tom-andersen requested a review from wu-hui October 28, 2024 15:47
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Nov 4, 2024
@tom-andersen tom-andersen merged commit d6bb0d2 into wuandy/JavaPplPP Nov 4, 2024
12 of 16 checks passed
@tom-andersen tom-andersen deleted the tomandersen/ppNewFunctions branch November 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-hui wu-hui Awaiting requested review from wu-hui

Assignees

@wu-hui wu-hui

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-andersen @wu-hui