Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid schema field mutation when passing selectedFields opt #1437

Merged
merged 7 commits into from
Feb 12, 2025
Merged

fix: avoid schema field mutation when passing selectedFields opt #1437

merged 7 commits into from
Feb 12, 2025
+85 −150

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Feb 11, 2025 •
edited
Loading

@alvarowolfx alvarowolfx requested review from a team as code owners February 11, 2025 14:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Feb 11, 2025
@alvarowolfx alvarowolfx mentioned this pull request Feb 11, 2025
Closed
7 tasks
leahecole
leahecole approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this but if @shollyman took a quick gander for posterity that wouldn't hurt

@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@alvarowolfx alvarowolfx added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@alvarowolfx
Copy link
Contributor Author

Adding do not merge tag since owlbot reverted Discovery changes

@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2025
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 12, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 12, 2025
@alvarowolfx alvarowolfx removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 12, 2025
@alvarowolfx alvarowolfx merged commit 27044d5 into main Feb 12, 2025
19 checks passed
@alvarowolfx alvarowolfx deleted the fix-get-rows-selected-fields branch February 12, 2025 14:13
@release-please release-please bot mentioned this pull request Feb 12, 2025
Merged
This was referenced Feb 18, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in table.getRows when using different selectedFields in consecutive calls
2 participants
@alvarowolfx @leahecole