Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types proxyquire #256

Merged
merged 4 commits into from
Nov 8, 2018
Merged

Add types proxyquire #256

merged 4 commits into from
Nov 8, 2018

Conversation

iida-hayato
Copy link
Contributor

@iida-hayato iida-hayato commented Nov 6, 2018 •
edited
Loading

Related #251

there is Error:(24, 29) TS2307: Cannot find module 'proxyquire'. when 'noImplicitAny: true' in tsconfig.json
So,I add @types/proxyquire

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2018
JustinBeckwith
JustinBeckwith approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JustinBeckwith JustinBeckwith merged commit 97ccb66 into googleapis:master Nov 8, 2018
@iida-hayato iida-hayato deleted the add-types-proxyquire branch November 8, 2018 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iida-hayato @JustinBeckwith @googlebot