-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip installation test if GOOGLE_CLOUD_TESTS_IN_VPCSC is passed #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this - could we do the thing you did in storage where we looked for an env var, and did an explicit skip? I don't want the kokoro configs straying if we can at all avoid it.
I changed it to use the environment variable to determine whether or not to skip install-test, but I still kept it split out |
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1 Continue to review full report at Codecov.
|
Split out install-test as a separate npm run-script instead of bundling
with system-test.
This helps unblock VPCSC testing since it can't fetch external
dependencies with npm install when installation test does npm pack