-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geo): add support for geography #397
Conversation
…d to be touched. tests totally failing
It looks like the lint task is being a bit faily. You could try running > @google-cloud/[email protected] posttest /tmpfs/src/github/nodejs-bigquery
> npm run check
> @google-cloud/[email protected] check /tmpfs/src/github/nodejs-bigquery
> gts check
/tmpfs/src/github/nodejs-bigquery/system-test/bigquery.ts
Lines: 1309-1321
table = dataset.table(generateName('table'));
return table.create({
schema: [
- 'date:DATE',
- 'datetime:DATETIME',
- 'time:TIME',
- 'timestamp:TIMESTAMP',
- 'numeric:NUMERIC',
- 'geography:GEOGRAPHY'
+ 'date:DATE', 'datetime:DATETIME', 'time:TIME', 'timestamp:TIMESTAMP',
+ 'numeric:NUMERIC', 'geography:GEOGRAPHY'
].join(', '),
});
});
clang-format reported errors... run `gts fix` to address. |
We should add some tests to the SQL Parameter system-tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming callmehiphop signs off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think all we're missing are some tests. We should make sure that we can
- use Geography as a SQL Parameter
- unit test that
GEOGRAPHY
returns aGeography
object.
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 99.45% 99.46% +<.01%
==========================================
Files 4 4
Lines 550 556 +6
Branches 76 76
==========================================
+ Hits 547 553 +6
Misses 2 2
Partials 1 1
Continue to review full report at Codecov.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming no new skipped tests are added
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
@JustinBeckwith @jkwlui can one of you please defeat the cursed cla 🤖 megaboss? |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
🎉 |
Trying to locate which portions of code need to be touched. tests totally failing!
Just seeking feedback on how this should actually be done.