feat: optionally wrap INT64 in BigQueryInt or provide a custom INT64 value type cast options #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #873 +/- ##
==========================================
+ Coverage 98.60% 98.65% +0.04%
==========================================
Files 9 9
Lines 6719 6967 +248
Branches 422 463 +41
==========================================
+ Hits 6625 6873 +248
Misses 94 94
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: bigquery
Co-authored-by: Stephen <[email protected]>
Co-authored-by: Stephen <[email protected]>
|
@steffnay What is the part that is a breaking change? It looks like an upgrade wouldn't break anything for a user, but let me know if I missed it. |
steffnay
changed the title
|
@stephenplusplus it's not breaking, updated the PR title. |
stephenplusplus
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to wrap 'INT64' values in a BigQueryInt type.
Add BigQueryInt class
Allow user to pass a custom typeCastFunction to be used to convert integer values
Give user option to specify schema fields to be converted by typeCastFunction
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #6 🦕