build!: update library to use Node 12 (#307)

* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · May 20, 2022 · d10a3af · d10a3af
1 parent 6d6d52b
commit d10a3af
Show file tree

Hide file tree

Showing 16 changed files with 9 additions and 146 deletions.
diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml
@@ -9,9 +9,9 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (10)
       - test (12)
       - test (14)
+      - test (16)
       - cla/google
       - windows
       - OwlBot Post Processor
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [10, 12, 14]
+        node: [12, 14, 16]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

diff --git a/.kokoro/continuous/node10/common.cfg b/.kokoro/continuous/node10/common.cfg
diff --git a/.kokoro/continuous/node10/docs.cfg b/.kokoro/continuous/node10/docs.cfg
diff --git a/.kokoro/continuous/node10/test.cfg b/.kokoro/continuous/node10/test.cfg
diff --git a/.kokoro/continuous/node8/common.cfg b/.kokoro/continuous/node8/common.cfg
diff --git a/.kokoro/continuous/node8/test.cfg b/.kokoro/continuous/node8/test.cfg
diff --git a/.kokoro/presubmit/node10/common.cfg b/.kokoro/presubmit/node10/common.cfg
diff --git a/.kokoro/presubmit/node10/docs.cfg b/.kokoro/presubmit/node10/docs.cfg
diff --git a/.kokoro/presubmit/node10/lint.cfg b/.kokoro/presubmit/node10/lint.cfg
diff --git a/.kokoro/presubmit/node10/test.cfg b/.kokoro/presubmit/node10/test.cfg
diff --git a/.kokoro/presubmit/node8/common.cfg b/.kokoro/presubmit/node8/common.cfg
diff --git a/.kokoro/presubmit/node8/test.cfg b/.kokoro/presubmit/node8/test.cfg
diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
   "main": "./build/src/index.js",
   "types": "./build/src/index.d.ts",
   "engines": {
-    "node": ">=10"
+    "node": ">=12.0.0"
   },
   "files": [
     "build/src"
@@ -46,13 +46,13 @@
     "c8": "^7.0.0",
     "express": "^4.17.1",
     "express-session": "^1.17.1",
-    "gts": "^3.0.0",
+    "gts": "^3.1.0",
     "jsdoc": "^3.5.5",
     "jsdoc-fresh": "^1.0.1",
     "jsdoc-region-tag": "^1.0.2",
     "linkinator": "^2.0.0",
-    "mocha": "^8.0.0",
+    "mocha": "^9.2.2",
     "pack-n-play": "^1.0.0-2",
-    "typescript": "~3.8.3"
+    "typescript": "^4.6.4"
   }
 }
diff --git a/samples/package.json b/samples/package.json
@@ -3,7 +3,7 @@
   "license": "Apache-2.0",
   "author": "Google LLC",
   "engines": {
-    "node": ">=8"
+    "node": ">=12.0.0"
   },
   "files": [
     "*.js"

diff --git a/src/index.ts b/src/index.ts
@@ -72,7 +72,7 @@ export class DatastoreStore extends expressSession.Store {
       try {
         result = JSON.parse(entity.data);
       } catch (er) {
-        return callback(er);
+        return callback(er as Error);
       }
 
       if (!entity.createdAt || !this.expirationMs) {
@@ -108,7 +108,7 @@ export class DatastoreStore extends expressSession.Store {
     try {
       sessJson = JSON.stringify(sess);
     } catch (err) {
-      return callback(err);
+      return callback(err as Error);
     }
 
     const createdAt = new Date();