Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Changed 'prefix' to 'kind' and added functionality to change datastore kind #56

Merged

Conversation

jake-tulip
Copy link

@jake-tulip jake-tulip commented Dec 7, 2018

Fixes #7

  • Prefix does nothing, and is not a datastore keyword. Changed it to kind as that is the actual keyword
  • Also updated the code so that 'Session' is overridden if the kind option is set
  • [👍] Tests and linter pass
  • [👍] Code coverage does not decrease (if any source code was changed)
  • [👍] Appropriate docs were updated (if necessary)

I've tested the change and it does change the kind in datastore.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2018
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix!

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2018
@JustinBeckwith JustinBeckwith merged commit 462db97 into googleapis:master Dec 9, 2018
@jake-tulip jake-tulip deleted the datastore-prefix-kind-fix branch December 11, 2018 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefix option doesn't seem to do anything
5 participants