This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Properly group records from a zonefile. #26
Merged
+95
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 250 264 +14
=====================================
+ Hits 250 264 +14
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Mar 14, 2018
| {DNS_DOMAIN} A 128.9.0.32 | ||
| A 10.1.0.52 | ||
| {DNS_DOMAIN} A 10.2.0.27 | ||
| A 128.9.0.33 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ghost
removed
the
cla: yes
Merged
|
@stephenplusplus Sorry. I worked around this issue by using another tool, so don't have anything handy to test with. Thanks for the fix though. When I have more time I'll revist where I had wanted to use this, as my current work around is a little hacky |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
cc @timwsuqld -- would you mind giving this a try?