Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tracing using OpenTelemetry. #2085

Merged
merged 6 commits into from
Jul 29, 2024
Merged

refactor: tracing using OpenTelemetry. #2085

merged 6 commits into from
Jul 29, 2024

Conversation

ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas self-assigned this Jul 15, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jul 15, 2024
@ehsannas ehsannas force-pushed the ehsann/otel-3 branch 3 times, most recently from 2caf5b6 to 39a3957 Compare July 15, 2024 23:07
@ehsannas ehsannas requested a review from milaGGL July 16, 2024 21:16
@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Jul 16, 2024
@ehsannas ehsannas marked this pull request as ready for review July 16, 2024 21:16
@ehsannas ehsannas requested review from a team as code owners July 16, 2024 21:16
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
dev/system-test/tracing.ts Outdated Show resolved Hide resolved
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
dev/system-test/tracing.ts Outdated Show resolved Hide resolved
milaGGL
milaGGL approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas changed the title feat: tracing using OpenTelemetry. refactor: tracing using OpenTelemetry. Jul 26, 2024
@ehsannas ehsannas merged commit e326e41 into main Jul 29, 2024
18 checks passed
@ehsannas ehsannas deleted the ehsann/otel-3 branch July 29, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimit-j-shah jimit-j-shah jimit-j-shah left review comments

@milaGGL milaGGL milaGGL approved these changes

Assignees

@milaGGL milaGGL

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @jimit-j-shah @milaGGL