Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove check for Protobuf version #474

Merged
merged 5 commits into from
Jul 11, 2024
Merged

fix: Remove check for Protobuf version #474

merged 5 commits into from
Jul 11, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 11, 2024

This PR removes the check for google.protobuf.__version__ and simply uses try, catch instead. If there is no attribute MessageMapContainer on _message , then the compatibility code introduced in #433 is used.

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
@parthea parthea requested a review from a team as a code owner July 11, 2024 18:51
parthea added 4 commits July 11, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants