-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests must not depend on environment variables #416
Labels
api: storage
Issues related to the googleapis/python-storage API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: process
A process-related concern. May include testing, release, or the like.
Comments
I'm working toward closing this issue in the PRs for the refactoring in #38:
Once those are merged, there will be many fewer tests to clean up: almost all of them deal with blob downloads: |
tseaver
added a commit
that referenced
this issue
Jun 8, 2021
Also, adjust 'Bucket.get_upload_policy' to use credentials from the client, rather than its connection. Remove last uses of '_Client' and '_Connection' shims: use a mocked client instead. Toward #416.
tseaver
added a commit
that referenced
this issue
Jun 8, 2021
tseaver
added a commit
that referenced
this issue
Jun 8, 2021
tseaver
added a commit
that referenced
this issue
Jun 8, 2021
tseaver
added a commit
that referenced
this issue
Jun 8, 2021
tseaver
added a commit
that referenced
this issue
Jun 9, 2021
Adjust 'Bucket.get_upload_policy' to use credentials from the client, rather than its connection. Closes #416.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this issue
Oct 13, 2021
Adjust 'Bucket.get_upload_policy' to use credentials from the client, rather than its connection. Closes googleapis#416.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this issue
Oct 13, 2021
Adjust 'Bucket.get_upload_policy' to use credentials from the client, rather than its connection. Closes googleapis#416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/python-storage API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: process
A process-related concern. May include testing, release, or the like.
E.g.,:
The text was updated successfully, but these errors were encountered: