Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate snippets for RetrySettings #2596

Closed
blakeli0 opened this issue Mar 21, 2024 · 0 comments · Fixed by #3056
Closed

Generate snippets for RetrySettings #2596

blakeli0 opened this issue Mar 21, 2024 · 0 comments · Fixed by #3056
Assignees
@alicejli
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@blakeli0
Copy link
Collaborator

Currently the generate TotalTimeout snippets(e.g. in Showcase) is misleading for customers per b/328302469. We should generate snippets for the whole RetrySettings instead of just TotalTimeout field reduce confusion.
@blakeli0 blakeli0 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. labels Mar 21, 2024
@alicejli alicejli self-assigned this Mar 21, 2024
@alicejli alicejli mentioned this issue Jul 23, 2024
Merged
blakeli0 pushed a commit that referenced this issue Sep 4, 2024
@alicejli
feat: add full RetrySettings sample code to Settings classes (#3056)
8fe3a2d 
Fixes #2596 ☕️
ldetmer pushed a commit that referenced this issue Sep 17, 2024
@alicejli @ldetmer
feat: add full RetrySettings sample code to Settings classes (#3056)
594a9e1 
Fixes #2596 ☕️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alicejli alicejli

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add full RetrySettings sample code to Settings classes googleapis/sdk-platform-java
2 participants
@blakeli0 @alicejli