Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove java-common-protos/.kokoro and enable renovate bot for requirements file. #1584

Merged
merged 12 commits into from
Mar 31, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Mar 29, 2023

Fixes #1485

Notable changes:

@mpeddada1 mpeddada1 requested a review from a team as a code owner March 29, 2023 21:55
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 29, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 29, 2023
@mpeddada1 mpeddada1 changed the title chore: unpin versions in requirements.in and enable renovate bot chore: upgrade cryptography and certifi versions in requirements.in and enable renovate bot Mar 29, 2023
@mpeddada1 mpeddada1 requested a review from meltsufin March 30, 2023 14:26
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use java-common-protos/.kokoro. (Let me know if you think otherwise)

Would you add a check (either this PR or another PR) to ensure these requirements files can be installed. It's great if we can use the same container image as we use in the release job.

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Mar 30, 2023

We don't use java-common-protos/.kokoro. (Let me know if you think otherwise)

Not sure if this is expected but I see that the nightly and presubmit jobs are still running but the release jobs haven't been executed since Nov, 2022. Does that mean that the .kokoro/release scripts for java-common-protos can be removed?

Screenshot 2023-03-30 at 10 41 50 AM

UPDATE:
Looking at the build log, these jobs are running for the old repo.

Would you add a check (either this PR or another PR) to ensure these requirements files can be installed. It's great if we can use the same container image as we use in the release job.

Sure! I'll work on adding the check in.

@mpeddada1 mpeddada1 requested a review from suztomo March 30, 2023 15:10
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Mar 31, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Mar 31, 2023
@mpeddada1
Copy link
Contributor Author

@suztomo I've removed the .kokoro directory from java-common-protos and added a check for requirements.txt. Could I get another review from you?

@mpeddada1 mpeddada1 changed the title chore: upgrade cryptography and certifi versions in requirements.in and enable renovate bot chore: remove java-common-protos/.kokoro and enable renovate bot for requirements file. Mar 31, 2023
steps:
- uses: actions/checkout@v3
- run: python3 --version
- run: python3 -m pip install --require-hashes -r .kokoro/requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Merge once all are green.

@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mpeddada1 mpeddada1 merged commit 2c2087c into main Mar 31, 2023
@mpeddada1 mpeddada1 deleted the clean-up-requirements branch March 31, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cryptography and certifi to resolve dependabot security alerts.
2 participants