chore: fix verify_library_generation.yaml for forks #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
reviewed
May 2, 2024
| @@ -21,7 +21,9 @@ jobs: | |||
| run: | | |||
| set -ex | |||
| git checkout "${base_ref}" | |||
| git fetch --no-tags --prune origin +${base_ref}:refs/remotes/origin/${base_ref} | |||
There was a problem hiding this comment.
Why git fetch after git checkout?
There was a problem hiding this comment.
It doesn't actually matter too much for L23-L24, but it's needed for L25/26 so that it can find the forked branches. I can revert this line if preferred.
There was a problem hiding this comment.
If it's not actually useful, I think we should revert it.
There was a problem hiding this comment.
Actually I think we do need it. Added some comments to explain.
JoeWang1127
reviewed
May 2, 2024
| git checkout "${head_ref}" | ||
| git fetch --no-tags --prune origin +${head_ref}:refs/remotes/origin/${head_ref} |
There was a problem hiding this comment.
Should we move this line before git checkout "${head_ref}"?
There was a problem hiding this comment.
Added comments to explain
…into fixVerify_library_generation
…gleapis/sdk-platform-java into fixVerify_library_generation
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: xs
JoeWang1127
reviewed
May 2, 2024
JoeWang1127
approved these changes
May 2, 2024
Co-authored-by: Joe Wang <[email protected]>
|
|
alicejli
added a commit
that referenced
this pull request
May 3, 2024
#2716 didn't quite fix what it should have. Follow up to fix the error: ``` Previous HEAD position was e54601f Merge 30c7c5b into 5d4567f Switched to a new branch 'main' branch 'main' set up to track 'origin/main'. + git fetch --no-tags --prune origin +main:refs/remotes/origin/main From https://github.com/googleapis/sdk-platform-java - [deleted] (none) -> origin/main + git checkout renovate/markupsafe-2.x error: pathspec 'renovate/markupsafe-2.x' did not match any file(s) known to git ``` --------- Co-authored-by: Joe Wang <[email protected]>
lqiu96
pushed a commit
that referenced
this pull request
May 22, 2024
PRs opened by renovate-bot are failing `verify_library_generation` because renovate-bot opens PRs from a fork rather than main. For instance #2657 is failing: ``` env: base_ref: main head_ref: renovate/markupsafe-2.x + git checkout main Previous HEAD position was d84e607 Merge 645951c into 766646a[13](https://github.com/googleapis/sdk-platform-java/actions/runs/8914757209/job/24482995077?pr=2657#step:3:13)3d1465dca Switched to a new branch 'main' branch 'main' set up to track 'origin/main'. + git checkout renovate/markupsafe-2.x error: pathspec 'renovate/markupsafe-2.x' did not match any file(s) known to git ``` This updates the yaml file to explicitly fetch specific branches which should fix the issue. --------- Co-authored-by: Joe Wang <[email protected]>
lqiu96
pushed a commit
that referenced
this pull request
May 22, 2024
#2716 didn't quite fix what it should have. Follow up to fix the error: ``` Previous HEAD position was e54601f Merge 30c7c5b into 5d4567f Switched to a new branch 'main' branch 'main' set up to track 'origin/main'. + git fetch --no-tags --prune origin +main:refs/remotes/origin/main From https://github.com/googleapis/sdk-platform-java - [deleted] (none) -> origin/main + git checkout renovate/markupsafe-2.x error: pathspec 'renovate/markupsafe-2.x' did not match any file(s) known to git ``` --------- Co-authored-by: Joe Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs opened by renovate-bot are failing
verify_library_generationbecause renovate-bot opens PRs from a fork rather than main.For instance #2657 is failing:
This updates the yaml file to explicitly fetch specific branches which should fix the issue.