-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for new setAllowHardBoundTokens field. #3467
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
09eb2b2
Add support for new setAllowHardBoundTokens field.
rmehta19 db51f4e
Merge branch 'main' into add-setting
rmehta19 fd1015e
Merge branch 'main' into add-setting
rmehta19 960084d
Clarify variable name in InstantiatingGrpcChannelProvider.
rmehta19 ddb3b79
Merge branch 'main' into add-setting
rmehta19 60dafd0
add setter for allowed hard bound token types to only the GRPC channe…
rmehta19 e193cc9
List not ArrayList, no setter, InternalApi.
rmehta19 0e40f22
add enum + javadocs.
rmehta19 6a27af6
Merge branch 'main' into add-setting
rmehta19 591ef68
mark enum as internal only.
rmehta19 90a32af
improve javadoc for setter.
rmehta19 a7f8384
add to existing unit test.
rmehta19 4fe44cb
Merge branch 'main' into add-setting
rmehta19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to also mark this as internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on making this internal as well.
Thinking twice about it though, I see that it is an
Experimental feature
, is it that we will always set the tokens to certain values? Or it's just this feature is not stable yet, internal teams could still set this to different values? If it's the former, then we don't have to introduce another public enum since they would be obsolete soon.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this should be marked as
Internal Api
, since this is intended to be set by client libraries. Done in 591ef68This is being marked as experimental for now, since we are in progress of adding the related logic (e.g #3548, #3572) and then piloting, as discussed in the internal doc + chat. When the feature is non-experimental, the field (
allowedHardBoundTokenTypes
) will be set for all gapics to include both (MTLS_S2A
andALTS
), however handwritten libraries will continue to set this field (allowedHardBoundTokenTypes
) themselves in their handwritten layer (e.g. GCS). Additionally, when it is non-experimental, gapics + handwritten libraries will have the option to override the default value of theallowedHardBoundTokenTypes
. I think the enum helps to proves clarity on the options.