ci: remove unnecessary distributionManagement section #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distributionManagement declared in the pom.xml files interferes the upload to GCP ArtifactRegistry because it tries to upload artifacts to google.oss.sonatype.org even when you try to upload artifacts to GCP Artifact Registry. The distributionManagement is already configured in the parent POM at https://github.com/googleapis/java-shared-config/blob/6d526a3129f585338b14dab8f041e56dbaae4cd5/native-image-shared-config/pom.xml#L42 No need redeclare in these pom.xml files.
suztomo
requested review from
meltsufin,
ldetmer,
jinseopkim0 and
burkedavison
meltsufin
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributionManagement declared in the pom.xml files interferes the upload to GCP ArtifactRegistry because it tries to
upload artifacts to google.oss.sonatype.org even when you try to upload artifacts to GCP Artifact Registry (b/377328233#comment9).
The distributionManagement is already configured in the parent POM at
https://github.com/googleapis/java-shared-config/blob/6d526a3129f585338b14dab8f041e56dbaae4cd5/native-image-shared-config/pom.xml#L42. No need redeclare in these pom.xml files.