Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependabot.yml template #1813

Merged
merged 2 commits into from
Jun 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions synthtool/gcp/templates/java_library/.github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ updates:
schedule:
interval: "daily"
# Disable version updates for Maven dependencies
open-pull-requests-limit: 0
# we use renovate-bot as well as shared-dependencies BOM to update maven dependencies.
ignore: "*"
- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "daily"
# Disable version updates for pip dependencies
open-pull-requests-limit: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already says "# Disable version updates for pip dependencies"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit

This option has no impact on security updates, which have a separate, internal limit of ten open pull requests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the security category is how this is leaking through.

Releases notes for the dependency list security in what was fixed.

Cryptography probably implicitly gets categorized as security

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

# If a security vulnerability comes in, we will be notified about
# it via template in the synthtool repository.
ignore: "*"