chore: update issue templates and codeowners #1993

sofisl · 2024-07-27T18:45:30Z

Hi @googleapis/jsteam-handwritten-libraries!

This PR changes a couple of templates, as requested:

Templates

Updates Bug templates to ask for more specific reproduction. Ask: please review the wording as this will go in your repo, and I'm not sure how much you want to distinguish repo-specific questions from API-specific questions (this seems like it would differ from the monorepo).
Adds a documentation request template for samples/questions on the library. Again, please read and update as necessary.
Feature request templates: Updates to distinguish API-specific FR from library requests.
Asks people to add non-library questions in discussions.
Adds a process request template for repo infra issues.
Codeowners: makes the vertical team the default, with the jsteam as secondary. Moreover, updates yoshi-team to jsteam, since AFAIK that team isn't maintained by twosync and seems really out of date. (You may have to add jsteam as a collaborator on your repo if it isn't already there)
Removing auto-approve use cases as we don't have security exemption to use them. Sorry!

Scripts

Close-invalid-link.cjs: Github is experimenting with .yaml files for templates but hasn't yet included response validation, so this is a hacky way of doing so. This script is fragile and is meant as a stop-gap until GH improves, see. If you make changes to bug template, you may have to update this script because its fragile.
Close-unresponse.cjs && remove-response-label.cjs: These scripts introduce a new functionality. As you're responding to issues and need a response from the OP, add a needs more info label. If the OP does not respond within 15 days, this script will automatically close the issue (does not apply if you don't respond). If the OP does respond, remove-response-label will remove the label so the timer stops.
Accompanying workflows are added for the scripts.

Ask: Much of this was copied over from google-cloud-node with minimal changes since I'm not really sure how API-specific libraries want to handle a lot of this language. Please go through and change the language on the templates (especially) as necessary!

Also, this does not need to hinge on me! Feel free to merge this PR while I'm gone and then merge it into your individual repos. I'll merge any remaining ones once I get back.

If the minority of repos don't want any of these changes at all, you can simply exclude it in your owlbot.py file (feel free to close the PR once it gets to your repo and add these files to be excluded). If the majority of repos don't want these changes, feel free to just close this PR.

synthtool/gcp/templates/node_library/.github/CODEOWNERS

synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/bug_report.md

synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/documentation_request.yaml

synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/feature_request.md

leahecole · 2024-08-12T18:22:41Z

synthtool/gcp/templates/node_library/.github/workflows/response.yml

+on:
+  schedule:
+    - cron: '30 1 * * *' # Run every day at 01:30
+  workflow_dispatch:


nit, this yaml is a .yml and all of the others are .yamls - request for consistency :)

leahecole · 2024-08-26T19:25:51Z

synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/questions.md

+name: Question
+about: If you have a question, please use Discussions
+


I see that most of the others were changed from markdown -> yaml - should this one be also?

Nope! It doesn't have any input fields.

I could see that, but there might also be some value in just making them consistent for later edits.

I'm going to keep it as is to discourage api-specific questions, see: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/common-validation-errors-when-creating-issue-forms#body-must-contain-at-least-one-non-markdown-field

leahecole · 2024-08-26T19:26:16Z

synthtool/gcp/templates/node_library/.github/auto-approve.yml

request for yaml not yml to be consistent

I don't think I should change this one: https://github.com/googleapis/repo-automation-bots/blob/bc1194c1fe6f08803f64cb847809c8692a955854/packages/auto-approve/src/auto-approve.ts#L45

Is it possible we could use .yml for the others above?

+1 that's fine too

synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/documentation_request.yaml

synthtool/gcp/templates/node_library/.github/CODEOWNERS

…009/files

feywind

This is pretty cool, I learned about some GitHub features :)

Just a few advisory comments.

feywind · 2024-09-16T19:35:57Z

synthtool/gcp/templates/node_library/.github/auto-approve.yml

Is it possible we could use .yml for the others above?

feywind · 2024-09-16T19:36:29Z

synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/questions.md

+name: Question
+about: If you have a question, please use Discussions
+


I could see that, but there might also be some value in just making them consistent for later edits.

feywind · 2024-09-16T19:37:41Z

synthtool/gcp/templates/node_library/.github/scripts/close-invalid-link.cjs

+        state: "closed"
+      });
+}
+module.exports = async ({ github, context }) => {


Do we want to change this to {github, context} to match the JS standards elsewhere? I know this is just a tiny one off though...

feywind · 2024-09-16T19:38:31Z

synthtool/gcp/templates/node_library/.github/scripts/close-unresponse.cjs

+  not been answered for ${numberOfDaysLimit} days. It can be reopened when the \
+  requested information is provided.`;
+
+  module.exports = async ({ github, context }) => {


Same comment and also I just noticed double quotes, if we do want to do it.

leahecole

left a +1 on one of megan's comments but nothing blocking on my end :)

leahecole · 2024-09-17T15:05:56Z

synthtool/gcp/templates/node_library/.github/auto-approve.yml

+1 that's fine too

sofisl added 2 commits July 27, 2024 11:19

chore: update issu templates and codeowners

ddabba9

remove extra file

7622ce9

sofisl requested a review from a team as a code owner July 27, 2024 18:45

blunderbuss-gcf bot assigned chingor13 Jul 27, 2024

Update close-invalid-link.cjs

4d3b5f5

sofisl assigned leahecole and danielbankhead Jul 29, 2024

leahecole requested changes Aug 12, 2024

View reviewed changes

sofisl requested a review from leahecole August 15, 2024 22:34

sofisl and others added 2 commits August 15, 2024 15:34

respond to comments

16e9e44

Merge branch 'master' into addTemplateChanges

77c9c38

leahecole requested changes Aug 26, 2024

View reviewed changes

sofisl requested a review from leahecole August 30, 2024 19:36

Update README.md like: https://github.com/googleapis/synthtool/pull/2…

1029e6e

…009/files

feywind approved these changes Sep 16, 2024

View reviewed changes

leahecole approved these changes Sep 17, 2024

View reviewed changes

synthtool/gcp/templates/node_library/.github/auto-approve.yml

- "NodeDependency"

Copy link

Contributor

leahecole Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 that's fine too

sofisl and others added 3 commits September 20, 2024 13:07

chore: address comments

26ae44e

make last yml consistent

61701a2

Merge branch 'master' into addTemplateChanges

344d771

sofisl merged commit bf182cd into master Sep 20, 2024
11 checks passed

sofisl deleted the addTemplateChanges branch September 20, 2024 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update issue templates and codeowners #1993

chore: update issue templates and codeowners #1993

sofisl commented Jul 27, 2024 •

edited

Loading

leahecole Aug 12, 2024

leahecole Aug 26, 2024

sofisl Aug 30, 2024

feywind Sep 16, 2024

sofisl Sep 20, 2024

leahecole Aug 26, 2024

sofisl Aug 30, 2024

feywind Sep 16, 2024

leahecole Sep 17, 2024

feywind left a comment

feywind Sep 16, 2024

feywind Sep 16, 2024

feywind Sep 16, 2024

feywind Sep 16, 2024

leahecole left a comment

leahecole Sep 17, 2024

		name: Question
		about: If you have a question, please use Discussions

chore: update issue templates and codeowners #1993

chore: update issue templates and codeowners #1993

Conversation

sofisl commented Jul 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feywind left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leahecole left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sofisl commented Jul 27, 2024 •

edited

Loading