-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: warn on too many concurrent requests #165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 74.87% 83.80% +8.93%
==========================================
Files 2 3 +1
Lines 410 630 +220
Branches 36 49 +13
==========================================
+ Hits 307 528 +221
+ Misses 103 102 -1
Continue to review full report at Codecov.
|
113da5e
to
4c7fa38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe let one more reviewer take a glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits, and one additional test that I think would be worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ideally once there's a test that we emit a process.on('warning')
event.
@bcoe your feedback was implemented, but there were some interface changes. can you take one more pass and confirm all OK? |
Fixes googleapis/nodejs-common#558 🦕
TEENY_REQUEST_WARN_CONCURRENT_REQUESTS
env var or usingteenyRequest.setStatOptions