Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

[ Dartify ] Using type specific to firestore #363

Closed
tperraut opened this issue Dec 1, 2020 · 6 comments · Fixed by #379
Closed

[ Dartify ] Using type specific to firestore #363

tperraut opened this issue Dec 1, 2020 · 6 comments · Fixed by #379
Assignees
@kevmoo

Comments

@tperraut
Copy link

tperraut commented Dec 1, 2020

The helper dartify is using firestore specific types like GeoPoint forcing to import the firebase-firestore.js dependencie in index.html without actually needing it.

Thank you for your work.
@kevmoo
Copy link
Contributor

kevmoo commented Dec 1, 2020 via email

@kevmoo
Copy link
Contributor

kevmoo commented Dec 16, 2020

What happens if you don't include firebase-firestore.js in your app?

@kevmoo kevmoo added the More information needed Waiting for information from the person who files the issue label Dec 16, 2020
@tperraut
Copy link
Author

tperraut commented Dec 16, 2020 via email

@kevmoo
Copy link
Contributor

kevmoo commented Dec 16, 2020 via email

@tperraut
Copy link
Author

tperraut commented Dec 16, 2020 •
edited
Loading

Yes in the console, pretty problematic in our app as it is really intensive on position changes. I think the dartify helper should not cast to GeoPoint if it is a Firebase realtime object and not a Firestore GeoPoint. I am not an expert of Firestore but for what I understood, a Geopoint is more than a simple object with latitude and longitude as people seems to have issues when creating an object with latitude and longitude and not marking it as a GeoPoint. (cf. #288 (comment))
On Firestore you can fix this by marking the actual object as a Geopoint in Firestore but for what I can tell, you cannot do that with Firebase realtime.

@no-response no-response bot removed the More information needed Waiting for information from the person who files the issue label Dec 16, 2020
kevmoo added a commit that referenced this issue Dec 16, 2020
@kevmoo
Improve testing of Firestore types
0056a75 
Fixes #288
Fixes #363
@kevmoo kevmoo mentioned this issue Dec 16, 2020
Merged
@kevmoo
Copy link
Contributor

kevmoo commented Dec 16, 2020

@tperraut – PR pending.

If you're adventurous, please pull it in as a dependency_override and check to see if it addresses things!

@kevmoo kevmoo self-assigned this Dec 16, 2020
kevmoo added a commit that referenced this issue Dec 16, 2020
@kevmoo
Improve testing of Firestore types (#379)
b1d345a 
Fixes #288
Fixes #364
Fixes #363
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevmoo kevmoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve testing of Firestore types googlearchive/firebase-dart
2 participants
@kevmoo @tperraut