Support panose from variable font export settings #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Feb 13, 2025
Comment on lines
+2596
to
+2601
| pub fn instance(&self, master: &FontMaster) -> Option<&Instance> { | ||
| self.instances | ||
| .iter() | ||
| .find(|i| i.active && i.type_ == InstanceType::Variable && i.name == master.name) | ||
| } | ||
|
|
There was a problem hiding this comment.
if this is only being used to find the default instance, maybe just a default_instance fn that didn't need to have the master passed in would be easier?
There was a problem hiding this comment.
I think there are going to be mroe cases
|
technically that's not an "instance" but a "variable font export setting" (they reused the same instance object and tacked on it a 'variable' attribute) |
anthrotype
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes panose match for GSC. JMM if happy.