[glypsh-reader] fix ParseIntError when custom param has unquoted string #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create a New Font from Glyphs.app and then add a 'Variable Font Origin' custom parameter (which we currently do support) and set this to the first and only master that the newly created font comes with (which Glyphs.app assigns the id of
m01
using an unquoted plist string), and then attempt to compile, you will get a ParseIntError when parsing the custom parameters, because glyphs-reader thinks that it is an integer.I add a reproducer first, and follow up with the actual fix.