[layout-normalizer] skip if GPOS not present #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the table is optional. Fixes #628
rsheeter
reviewed
Dec 6, 2023
| let table = font | ||
| .gpos() | ||
| .map_err(|_| Error::MissingTable(Tag::new(b"GPOS")))?; | ||
| let Some(table) = font.gpos().ok() else { |
There was a problem hiding this comment.
Nit: I think you can match so w/o .ok()?
Nit2: Arguably we should fail on any error except there is no GPOS table whereas we are assuming here the only error possible is missing. That's a problem before and after so I wouldn't block on it.
rsheeter
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the table is optional. Fixes #628