Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSC to crater #9

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Add GSC to crater #9

merged 2 commits into from
Feb 14, 2025

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Feb 11, 2025

@chrissimpkins
Copy link
Member

We can make the directory path update. I reached out to @belluzj today to see what we need to do in the CI build workflow to accommodate this path change.

@MariannaPaszkowska for future reference, we should begin to use sources regularly for our source directory paths to support the crater requirements here.

@cmyr
Copy link
Member

cmyr commented Feb 11, 2025

And to clarify, we expect sources because that is what is used in the google-fonts-project-template: https://github.com/googlefonts/googlefonts-project-template/blob/main/sources/config.yaml

@chrissimpkins
Copy link
Member

@anthrotype
Copy link
Member

wouldn't it be hilarious if, by the time we do add GSC to fontc_crater, we don't even see it listed because the "output is identical" already 😄

@rsheeter
Copy link
Contributor Author

wouldn't it be hilarious if, by the time we do add GSC to fontc_crater, we don't even see it listed because the "output is identical" already 😄

I believe that's expected rofl.

@cmyr cmyr merged commit 8a574c9 into main Feb 14, 2025
1 check passed
@cmyr cmyr deleted the rsheeter-patch-1 branch February 14, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants