Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark glyphs with incorrect contour directions #86

Closed
m4rc1e opened this issue Nov 11, 2020 · 7 comments · Fixed by #87
Closed

Mark glyphs with incorrect contour directions #86

m4rc1e opened this issue Nov 11, 2020 · 7 comments · Fixed by #87

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 11, 2020

If a mark glyph is used a component in another glyph and its contour orientation differs from the base glyph, the marks will appear lighter in OS X. For this family, I can see that the double grave accent's has this issue (there may be more).

roboto1

Ȑ double grave appears lighter. Issue also happens in Ѷ ѷ Ȁ ȁ Ȅ ȅ Ȉ ȉ Ȍ ȍ Ȑ ȑ Ȕ ȕ Ȕ

To solve this issue, we must do the following:

  • Find all mark glyphs which are used in composite glyphs whose contour directions are incorrect
  • Fix the orientation for the mark glyphs we found above
  • Rehint the mark glyphs
  • Bump version and repush

Imo this is a blocker and we must solve this issue before we can release the family. We discovered this issue whilst reviewing Asap, davelab6/Asap#6

cc @davelab6 @dberlow @moyogo

@dberlow
Copy link
Contributor

dberlow commented Nov 11, 2020

According to the sources, (U+030F) reversal includes Roman and italic.

@mikedug
Copy link
Contributor

mikedug commented Nov 11, 2020

the contours for (U+030F) , compared to Unicode 0210, look to be the same orientation in VTT in the Roboto Variable. Am I missing something?[]
0X30F
(url)

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Nov 11, 2020

the contours for (U+030F) , compared to Unicode 0210, look to be the same orientation in VTT in the Roboto Variable. Am I missing something?[]

If we inspect uni210, the base component "R" is anticlockwise, whilst the mark component "double tilde" is clockwise.

@mikedug
Copy link
Contributor

mikedug commented Nov 11, 2020

ok, thanks. I see the R as clockwise and the accent as anti-clockwise, in the illustration above.

@davelab6
Copy link
Member

davelab6 commented Nov 12, 2020

But, either way, they are opposite directions, but they should be the same directions.

@m4rc1e please can you file a fontbakery issue to check for this, and fix Roboto directly.

@dberlow
Copy link
Contributor

dberlow commented Nov 12, 2020 via email

@davelab6
Copy link
Member

I believe this is a minor production issue, which will take Marc 4-8 hours to do, and so with other high priority FB projects going on, its best for Marc to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants