-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first 32 control chars #100
Conversation
Just like to point out that these characters are only getting added to the Android cut. They're being mapped to the first empty glyph in the font. |
@chrissimpkins here's a link to the generated fonts, https://github.com/googlefonts/roboto-classic/suites/7273375516/artifacts/292791016 |
Here's a diffenator2 report (tool still wip) We can see that the cmap has been changes as expected. |
Thanks Marc! I will reach out to the team to confirm that this works for them and discuss the next step. |
Thanks! I'll be away from today until the 20th of July so if the team is happy, you may need to find someone (or yourself) to cut a release. It's fairly straight forward, you can create a release using the github gui and just attach the fonts generated by the ci. |
I reached out to Android team today to followup on this request. We are waiting on confirmation that this addresses the issue. cc @RosaWagner |
I believe the customer team accepted this, so can be merged |
Cool. I'll merge this and then add #97 and cut a new release. |
Thanks Marc! |
As requested by the Android team. Supersedes #96, Fixes #98, #99
@chrissimpkins. Once the CI is done making the fonts, I'll post the link so the team can test.