Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first 32 control chars #100

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Add first 32 control chars #100

merged 7 commits into from
Jul 26, 2022

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Jul 8, 2022

As requested by the Android team. Supersedes #96, Fixes #98, #99

@chrissimpkins. Once the CI is done making the fonts, I'll post the link so the team can test.

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jul 8, 2022

Just like to point out that these characters are only getting added to the Android cut. They're being mapped to the first empty glyph in the font.

@m4rc1e m4rc1e requested a review from chrissimpkins July 8, 2022 11:04
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jul 8, 2022

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jul 8, 2022

Here's a diffenator2 report (tool still wip)

report.zip

We can see that the cmap has been changes as expected.

Screenshot 2022-07-08 at 12 22 11

@chrissimpkins
Copy link
Member

chrissimpkins commented Jul 8, 2022

Thanks Marc! I will reach out to the team to confirm that this works for them and discuss the next step.

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jul 8, 2022

Thanks! I'll be away from today until the 20th of July so if the team is happy, you may need to find someone (or yourself) to cut a release. It's fairly straight forward, you can create a release using the github gui and just attach the fonts generated by the ci.

@chrissimpkins
Copy link
Member

chrissimpkins commented Jul 20, 2022

I reached out to Android team today to followup on this request. We are waiting on confirmation that this addresses the issue.

cc @RosaWagner

@davelab6
Copy link
Member

I believe the customer team accepted this, so can be merged

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jul 26, 2022

Cool. I'll merge this and then add #97 and cut a new release.

@chrissimpkins
Copy link
Member

Thanks Marc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add non-printable ASCII control characters mapped to empty glyph
3 participants