Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge grafana.yaml and grafana-frontend.yaml #2994

Closed
zmerlynn opened this issue Feb 23, 2023 · 5 comments
Closed

Converge grafana.yaml and grafana-frontend.yaml #2994

zmerlynn opened this issue Feb 23, 2023 · 5 comments
Labels
kind/bug These are bugs. obsolete stale Pending closure unless there is a strong objection.

Comments

@zmerlynn
Copy link
Collaborator

Follow up to #2990 (comment): after #2990 goes in, let's figure out how to maybe converge these manifests.

@zmerlynn
Copy link
Collaborator Author

Also leaving breadcrumbs: We need the frontend service as an authentication proxy. I'd love to get rid of it entirely, but that is blocked on: grafana/grafana#40844 (reply in thread) - if that issue goes away, we can remove grafana-frontend.yaml entirely.

Copy link

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Apr 15, 2024
@markmandel
Copy link
Collaborator

Maybe a good use for kustomize ? to only have a single yaml reference, but can change the datasources.url as needed?

@markmandel markmandel removed the stale Pending closure unless there is a strong objection. label May 23, 2024
Copy link

github-actions bot commented Jul 1, 2024

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Jul 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue is marked as obsolete due to inactivity for last 60 days. To avoid issue getting closed in next 30 days, please add a comment or add 'awaiting-maintainer' label. Thank you for your contributions

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. obsolete stale Pending closure unless there is a strong objection.
Projects
None yet
Development

No branches or pull requests

2 participants