Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration guide for Google Cloud Managed Service for Prometheus #2990

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Feb 23, 2023

Adds a guide plus two additional manifests to help with install for Managed Prometheus. Install tested on 1.25 Autopilot.

Gated on 1.30 release because I made a handful of changes to Grafana charts to accomodate GMP - the charts won't work in previous versions, but the metric collection would be fine. Regardless, we're super close to the release date anyways, so I think it's fine to gate it.

Towards #2777 indirectly (the standard Prometheus install doesn't work on Autopilot).

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 73d955a9-4f2c-454f-81ca-7f61e8c409db

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2990/head:pr_2990 && git checkout pr_2990
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-89d290e-amd64

site/content/en/docs/Guides/metrics.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/metrics.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/metrics.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/metrics.md Outdated Show resolved Hide resolved
build/grafana-frontend.yaml Show resolved Hide resolved
Adds a guide plus two additional manifests to help with install for
Managed Prometheus. Install tested on 1.25 Autopilot.
@zmerlynn
Copy link
Collaborator Author

Thanks for the review, @roberthbailey! PTAL

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just waiting for the website to render to make sure the links all work as expected.

@zmerlynn
Copy link
Collaborator Author

Looks like https://0774a91-dot-preview-dot-agones-images.appspot.com/site/ is available now.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: da082780-e3c7-4348-8e5e-4d109e13c0e8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2990/head:pr_2990 && git checkout pr_2990
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-0774a91-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Feb 24, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added approved and removed lgtm labels Feb 24, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@roberthbailey roberthbailey enabled auto-merge (squash) February 24, 2023 18:35
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 426f18d8-1b5c-49a3-a7cd-f524458073fe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2990/head:pr_2990 && git checkout pr_2990
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-dee60ba-amd64

@roberthbailey roberthbailey merged commit b901261 into googleforgames:main Feb 24, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/feature New features for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants