Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform fix AKS Node Pool Labels #1420

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Mar 19, 2020

Now Agones controllers are deployed in Agones System node pool.

Closes #1383 .

Now Agones controller is scheduled to the right node:
aks-system-55978144-vmss000000/10.240.0.6

kubectl describe pod agones-controller-fb6798699-cb87l --namespace agones-system                                                                                      
Name:                 agones-controller-fb6798699-cb87l
Namespace:            agones-system
Priority:             1000000
Priority Class Name:  agones-system
Node:                 aks-system-55978144-vmss000000/10.240.0.6
Start Time:           Thu, 19 Mar 2020 18:57:00 +0300
Labels:               agones.dev/role=controller
                      app=agones
                      heritage=Tiller
                      pod-template-hash=fb6798699
                      release=agones                                                                                                                                                                     
Annotations:          cluster-autoscaler.kubernetes.io/safe-to-evict: false                                                                                                                              
                      prometheus.io/path: /metrics                                                                                                                                                       
                      prometheus.io/port: 8080                                                                                                                                                           
                      prometheus.io/scrape: true                                                                                                                                                         
                      revision/tls-cert: 1

Now Agones controllers are deployed in Agones System node pool.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ef4cf1f7-429e-42ed-b9e1-50ad272cbe0a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1420/head:pr_1420 && git checkout pr_1420
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-0f23a6e

Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@markmandel markmandel merged commit 82d8945 into googleforgames:master Mar 23, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/bug These are bugs. labels Mar 23, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Now Agones controllers are deployed in Agones System node pool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/bug These are bugs. lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AKS labels are not supported in the Terraform provider, wrong Controller placement
4 participants