Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk arm64 images #2521

Merged
merged 132 commits into from
Apr 29, 2022
Merged
Changes from 1 commit
Commits
Show all changes
132 commits
Select commit Hold shift + click to select a range
680f316
Build both arm64 and amd64 sdk img
Ludea Mar 23, 2022
0281ab4
Use arch variable
Ludea Mar 23, 2022
a4b2b5c
Don't use --build-arg when building on amd64, it's the default value
Ludea Mar 23, 2022
2a94635
enable binfmt
Ludea Mar 23, 2022
1c4fa4c
try without quotes
Ludea Mar 23, 2022
ba446c3
debug
Ludea Mar 23, 2022
bc21738
docker info
Ludea Mar 23, 2022
00192de
try with DOCKER_BUILD_KIT=1 DOCKER_CLI_EXPERIMENTAL=enabled
Ludea Mar 23, 2022
2718501
use buildx into build-agones-sdk-image-arm64 step
Ludea Mar 23, 2022
a568924
don't setup binfmt
Ludea Mar 23, 2022
c55df8c
revert to docker -version
Ludea Mar 23, 2022
a16e560
create a new buildx instance
Ludea Mar 23, 2022
fd8f24e
delete amd64 tag
Ludea Mar 23, 2022
b07d874
Use ensure-buildx step only into arm64 step
Ludea Mar 23, 2022
d9a344c
Remove ensure-buildx step
Ludea Mar 23, 2022
7e72b16
Move ensure-buildx into main Makefile
Ludea Mar 23, 2022
8ddbbdd
Move license and src step to sdk parent step
Ludea Mar 23, 2022
1993529
Use builder option
Ludea Mar 24, 2022
2e0db94
Use docker buildx use
Ludea Mar 24, 2022
adef581
Try this
Ludea Mar 24, 2022
7d0b00e
Try this
Ludea Mar 24, 2022
1b3ee2a
Update docker to 20.10.3
Ludea Mar 25, 2022
12019d4
Use --builder option
Ludea Mar 25, 2022
4661fb6
Merge branch 'main' into arm_images
Ludea Mar 25, 2022
a5c8069
Restore deleted step
Ludea Mar 25, 2022
9b6cf0d
Try WITH_ARM=0
Ludea Apr 1, 2022
1fe21fb
Debug
Ludea Apr 1, 2022
853e164
Missing arm64 sdk server img
Ludea Apr 1, 2022
0f360d9
Missing endif
Ludea Apr 1, 2022
588e182
Delete imagetools
Ludea Apr 1, 2022
218c81f
Delete buildx inspect
Ludea Apr 1, 2022
191d411
Delete expérimental and add arch argument for sdk img
Ludea Apr 1, 2022
9920f73
Try this
Ludea Apr 1, 2022
65bd25b
Improve sdk server img build
Ludea Apr 1, 2022
f7c9481
Fix wrong builder
Ludea Apr 1, 2022
3fa1b38
Try this
Ludea Apr 1, 2022
bbd1490
Delete manifest
Ludea Apr 1, 2022
7623c4d
Fix manifest
Ludea Apr 1, 2022
54a6d8f
Fix manifest tag
Ludea Apr 1, 2022
a7610da
Arm img tag and use amend flag
Ludea Apr 1, 2022
11891ef
Push arm img
Ludea Apr 1, 2022
415a44a
Typo
Ludea Apr 1, 2022
1c36f27
Improve push sdk img
Ludea Apr 1, 2022
5b5f4d9
Typo
Ludea Apr 1, 2022
f54efc5
Don't use amend flag
Ludea Apr 1, 2022
439fdce
Fix arm64 push command and re enable amend flag
Ludea Apr 1, 2022
e12de03
Try this
Ludea Apr 1, 2022
49020b9
Space
Ludea Apr 1, 2022
f064809
Try this
Ludea Apr 1, 2022
0a7fd8d
Debug
Ludea Apr 2, 2022
2b477a1
debug
Ludea Apr 2, 2022
01c06cf
Debug
Ludea Apr 2, 2022
4f8d5e8
debug
Ludea Apr 2, 2022
c8faf7c
Debug
Ludea Apr 2, 2022
9416890
debug
Ludea Apr 2, 2022
980ea1b
debug
Ludea Apr 2, 2022
c1d2765
debug
Ludea Apr 2, 2022
7d176ce
debug
Ludea Apr 2, 2022
a684f1c
debug
Ludea Apr 2, 2022
db76522
debug
Ludea Apr 2, 2022
be2015f
debug
Ludea Apr 2, 2022
8489fa2
Debug
Ludea Apr 2, 2022
52ddde2
debug
Ludea Apr 2, 2022
09a3b15
Debug
Ludea Apr 2, 2022
2239529
Debug
Ludea Apr 2, 2022
2600247
Debug
Ludea Apr 2, 2022
0a0e913
Debug
Ludea Apr 2, 2022
b37a284
Debug
Ludea Apr 2, 2022
d006212
Debug
Ludea Apr 2, 2022
6367cc5
Debug
Ludea Apr 2, 2022
a0fe3d3
Debug
Ludea Apr 2, 2022
42ebbf2
Debug
Ludea Apr 2, 2022
c299380
Debug
Ludea Apr 2, 2022
aa9772b
Debug
Ludea Apr 2, 2022
ba62fd8
Debug
Ludea Apr 2, 2022
6f735d1
Enable binfmt
Ludea Apr 3, 2022
b258453
Enable binfmt into ci
Ludea Apr 3, 2022
49d7503
Typo
Ludea Apr 3, 2022
37874bb
Debug
Ludea Apr 3, 2022
0278654
Debug
Ludea Apr 3, 2022
404738e
Debug
Ludea Apr 3, 2022
1f3a184
Use linuxkit binfmt img
Ludea Apr 3, 2022
c72abe0
Debug
Ludea Apr 3, 2022
b59ccf0
Remove useless target
Ludea Apr 3, 2022
244671b
Docs
Ludea Apr 3, 2022
26972b0
Typo
Ludea Apr 3, 2022
4632cbe
Debug
Ludea Apr 3, 2022
01b1098
Debug
Ludea Apr 3, 2022
7dcfa4b
Debug
Ludea Apr 3, 2022
a481d42
Debug
Ludea Apr 3, 2022
2b85666
Debug
Ludea Apr 3, 2022
5726bf5
Debug
Ludea Apr 3, 2022
45c4ec2
Debug
Ludea Apr 3, 2022
06b4f10
Debug
Ludea Apr 3, 2022
a24e7fd
Typo
Ludea Apr 3, 2022
c69489a
Debug
Ludea Apr 3, 2022
5249ef3
Merge branch 'main' into arm_images
Ludea Apr 6, 2022
a667bd1
Merge branch 'main' into arm_images
Ludea Apr 7, 2022
2b27ace
Merge branch 'main' into arm_images
Ludea Apr 7, 2022
c2ed4ed
Merge branch 'main' into arm_images
Ludea Apr 8, 2022
fa32f51
remove TODO
Ludea Apr 8, 2022
42b5645
remove docker command debug
Ludea Apr 8, 2022
c71e622
move binfmt to makefile to build arm64 image on local machine
Ludea Apr 8, 2022
b0a3095
remove binfmt from cloudbuild
Ludea Apr 8, 2022
c391778
Merge branch 'main' into arm_images
Ludea Apr 8, 2022
0c087c6
Remove tag since cloudBuild use 20.x.x.
Ludea Apr 16, 2022
cdf9e95
Merge branch 'main' into arm_images
Ludea Apr 16, 2022
e4e10d9
Remove useless step
Ludea Apr 19, 2022
5fe6db7
Use Cloud builder 20.10.13
Ludea Apr 19, 2022
f57db57
Install binfmt when creating build-image
Ludea Apr 19, 2022
0de6411
Delete step
Ludea Apr 19, 2022
5746995
Typo
Ludea Apr 19, 2022
6ebd31b
Merge branch 'main' into arm_images
Ludea Apr 21, 2022
f88e15e
Merge branch 'main' into arm_images
Ludea Apr 21, 2022
97c9e83
Merge branch 'main' into arm_images
markmandel Apr 21, 2022
822c4c3
Feedback
Ludea Apr 22, 2022
6d9e0ef
Merge branch 'main' into arm_images
Ludea Apr 22, 2022
140816b
remove debugging command
Ludea Apr 22, 2022
2d91f88
delete useless variable
Ludea Apr 22, 2022
2c4574e
Initial cleanup.
markmandel Apr 22, 2022
9986756
remove duplicated step
Ludea Apr 25, 2022
030b09b
Merge branch 'arm_images' into pr/arm_images
Ludea Apr 25, 2022
e80be72
Merge pull request #1 from markmandel/pr/arm_images
Ludea Apr 25, 2022
dae4c85
remove useless target
Ludea Apr 25, 2022
af45e9d
Merge branch 'main' into arm_images
Ludea Apr 25, 2022
3b1e6c4
Merge branch 'main' into arm_images
Ludea Apr 26, 2022
ec06756
Merge branch 'main' into arm_images
Ludea Apr 26, 2022
7a0c947
Merge branch 'main' into arm_images
Ludea Apr 26, 2022
6e2082d
Merge branch 'main' into arm_images
Ludea Apr 27, 2022
855d17d
Merge branch 'main' into arm_images
Ludea Apr 28, 2022
09f19f8
Merge branch 'main' into arm_images
roberthbailey Apr 28, 2022
01b960a
Remove comment
Ludea Apr 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix manifest tag
Ludea authored Apr 1, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 54a6d8f58edd1187fcfbe2ef142b0d59c9a4229a
4 changes: 2 additions & 2 deletions build/Makefile
Original file line number Diff line number Diff line change
@@ -514,13 +514,13 @@ ifeq ($(WITH_WINDOWS), 1)
# push the gameservers sidecar image
push-agones-sdk-image: push-agones-sdk-linux-image
# Ensure that the sidecar manifest is removed before creating a new one.
-DOCKER_CLI_EXPERIMENTAL=enabled docker manifest rm $(sidecar_tag_amd64_tag)
-DOCKER_CLI_EXPERIMENTAL=enabled docker manifest rm $(sidecar_linux_amd64_tag)
# Using docker buildx with foreign OSes is a bit awkward. Since the layers but not the tag
# was cached we have to rebuild the image (which should be fast since it's cached).
$(MAKE) WINDOWS_DOCKER_PUSH_ARGS=--push build-agones-sdk-image-windows
# Agones should start using the -linux_amd64 suffix for Linux images. This allows multi-arch support in the future.
DOCKER_CLI_EXPERIMENTAL=enabled docker manifest create $(sidecar_linux_amd64_tag) $(foreach windows_version, $(WINDOWS_VERSIONS), $(sidecar_tag)-windows_amd64-$(windows_version))
DOCKER_CLI_EXPERIMENTAL=enabled docker manifest push $(sidecar_tag_amd64_tag)
DOCKER_CLI_EXPERIMENTAL=enabled docker manifest push $(sidecar_linux_amd64_tag)
else
push-agones-sdk-image: push-agones-sdk-linux-image
endif