-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go version to 1.19.1 #2743
Conversation
Build Failed 😱 Build Id: 8ee316fb-bb65-45c1-aa56-62cc17e76b4e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 2f656bbf-4d22-4666-a5ee-75bf04897ad3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 1a9ceb29-e8fd-46c0-a3f8-cdc056a4df6e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: f0e0d344-f5f7-4d4f-aa1e-190e3a147ec3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
e2e tests failed, but it looks like it may have been a flake. I'm rerunning them to see if they fail the same way again. |
Build Failed 😱 Build Id: b133b1fd-6930-416b-b2a0-4565a58f0178 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
The same test failed but in e2e-feature-gates this time. It looks like something strange is going on. The test failure has a bunch of lines like this: Looking at the code where this message is printed we expect it to be printed once and then the background go routine to exit and the test to finish successfully. I'm wondering if the changes to the go memory model might be related, but we are seeing the atomic signaling working correctly (the log is printed) - what we aren't seeing is the go routine exit afterwords by executing the return statement. I copied the relevant code into the go playground to see if that would reproduce the error but it seems to execute properly: https://go.dev/play/p/0JNOPFLbjw8 |
Build Succeeded 👏 Build Id: 33bec621-fc15-474d-b153-c512a2a7d7cf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
kind cleanup
What this PR does / Why we need it:
Upgrade go version to 1.19.1 and bump the example images version
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: