Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version to 1.19.1 #2743

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Sep 20, 2022

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Upgrade go version to 1.19.1 and bump the example images version

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@gongmax gongmax changed the title Go 1.19 Upgrade Go version to 1.19.1 Sep 20, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8ee316fb-bb65-45c1-aa56-62cc17e76b4e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2f656bbf-4d22-4666-a5ee-75bf04897ad3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1a9ceb29-e8fd-46c0-a3f8-cdc056a4df6e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f0e0d344-f5f7-4d4f-aa1e-190e3a147ec3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

e2e tests failed, but it looks like it may have been a flake. I'm rerunning them to see if they fail the same way again.

.golangci.yml Show resolved Hide resolved
site/go.mod Show resolved Hide resolved
test/e2e/fleet_test.go Outdated Show resolved Hide resolved
test/e2e/gameserver_test.go Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b133b1fd-6930-416b-b2a0-4565a58f0178

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

The same test failed but in e2e-feature-gates this time. It looks like something strange is going on.

The test failure has a bunch of lines like this: time="2022-09-23 04:01:31.215" level=info msg="UDP Crash stop signal received. Stopping." test=TestGameServerUnhealthyAfterReadyCrash

Looking at the code where this message is printed we expect it to be printed once and then the background go routine to exit and the test to finish successfully.

I'm wondering if the changes to the go memory model might be related, but we are seeing the atomic signaling working correctly (the log is printed) - what we aren't seeing is the go routine exit afterwords by executing the return statement.

I copied the relevant code into the go playground to see if that would reproduce the error but it seems to execute properly: https://go.dev/play/p/0JNOPFLbjw8

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 33bec621-fc15-474d-b153-c512a2a7d7cf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2743/head:pr_2743 && git checkout pr_2743
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-b80b1a2-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 261d808 into googleforgames:main Sep 23, 2022
@mangalpalli mangalpalli added this to the 1.27.0 milestone Oct 18, 2022
@gongmax gongmax mentioned this pull request Oct 19, 2022
@roberthbailey roberthbailey added the kind/feature New features for Agones label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants