Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of the io/ioutil package #2752

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Sep 26, 2022

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
"io/ioutil" has been deprecated since Go 1.16, this PR made the necessary change to remove its usage
Which issue(s) this PR fixes:

Closes #2748

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 233f8961-4c3e-4b77-aac7-eda5a5f18860

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2752/head:pr_2752 && git checkout pr_2752
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-518948a-amd64

@gongmax gongmax marked this pull request as ready for review September 26, 2022 20:12
@google-oss-prow google-oss-prow bot added the lgtm label Sep 26, 2022
@roberthbailey roberthbailey merged commit dc3eb37 into googleforgames:main Sep 26, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax deleted the ioutil-deperacate branch September 26, 2022 20:49
@mangalpalli mangalpalli added this to the 1.27.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace uses of the io/ioutil package
4 participants