Enable image streaming everywhere by default #2756
Conversation
|
Build Succeeded 👏 Build Id: 1420d94b-9132-43c9-b029-35d904ecf6a0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -88,6 +88,7 @@ gcloud container clusters create [CLUSTER_NAME] --cluster-version={{% k8s-versio | |||
| --scopes=gke-default \ | |||
| --num-nodes=4 \ | |||
| --no-enable-autoupgrade \ | |||
| --enable-image-streaming \ | |||
There was a problem hiding this comment.
For changes to the website, we generally gate them so that they do not appear until the next release. Even though this doesn't require new features in Agones, I think it still makes sense to wait to publish this guidance until our next release (which reminds me that we should also recreate the e2e test cluster using your terraform scripts so that our testing starts to use this configuration as well).
https://agones.dev/site/docs/contribute/#within-a-page describes how to add the feature gate tags to the website pages.
There was a problem hiding this comment.
Thanks for the context. Fixed it in next commit.
Looks like the line {{% feature publishVersion="1.27.0" %}} and {{% /feature %}} introduce new lines automatically so I have to add them in the same line with the content to be hidden to avoid messing up the format. Verified via make site-server and make site-server ENV=RELEASE_VERSION=1.26.0 ARGS=
| @@ -85,6 +85,7 @@ Configurable parameters: | |||
| - agones_version - the version of agones to install (an empty string, which is the default, is the latest version from the [Helm repository](https://agones.dev/chart/stable)) | |||
| - machine_type - machine type for hosting game servers (default is "e2-standard-4") | |||
| - node_count - count of game server nodes for the default node pool (default is "4") | |||
| - enable_image_streaming - whether or not to enable image streaming for the `"default"` node pool (default is true) | |||
There was a problem hiding this comment.
This needs a feature gate as well.
There was a problem hiding this comment.
Addressed in the second commit.
|
@markmandel - since you created #2746 would you like to take a review pass on this as well? |
…treaming attribute
|
Build Succeeded 👏 Build Id: 1775fb6a-7481-4113-b233-84f67a186844 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: b28ec8b3-256f-4c10-a97a-a7c29111f43f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Update the installation guide for GKE, and Terraform scripts to default to enable image processing. Always enable image streaming for the
"agones-system"and"agones-metrics"node pool. Enable image streaming for the"default"by default but user can change the setting.Verified the change works by recreating my clusters and run
kubectl get events --all-namespaces, saw the event log entries likeImage ... is backed by image streamingfor all the three node pools.Which issue(s) this PR fixes:
Closes #2746
Special notes for your reviewer: